-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve dicom tag browser #4451
base: master
Are you sure you want to change the base?
feat: improve dicom tag browser #4451
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@fedorov you can test it here: https://deploy-preview-4451--ohif-dev.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're introducing a new UI library (Ant Design) into OHIF, which doesn't align with our planned migration to shadcn/ui tables. I can't merge this until it uses the shadcn/ui table component.
It doesn't because you searched for a nested item. In this case it won't. Try without searching and you'll see it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new change Pedro, it's much better, but like Alireza said, we are using shadcn for all the new components, look at @ohif/ui-next, and https://ui.shadcn.com/, define the components you need in ui-next using shadcn, then import them in the dicom tag browser to build the desired behavior.
Please revise this PR by tomorrow to include it in 3.9; otherwise, it will be moved to 3.10-beta. Thanks. |
I have other priorities right now. This PR will probably have to wait a few weeks, unfortunately. |
Context
Addresses: #2372
Changes & Results
Collapse and expand items:
Deep search:
Use slider to navigate between series instances:
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment