-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat mammo hanging protocol #4445
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks a lot! |
export const mgCC = { | ||
id: 'mgCC', | ||
name: 'mammo-cc', | ||
imageLoadStrategy: 'interleaveTopToBottom', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the image load strategy out now - it is better handled with the progressive loading.
name: 'mammo-cc', | ||
imageLoadStrategy: 'interleaveTopToBottom', | ||
protocolMatchingRules: [ | ||
{ attribute: 'ModalitiesInStudy', constraint: { contains: ['MG', 'DX'] } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this probably needs a better rule so it doesn't trigger too often. We really need to add a way to have a constraint X and constraint Y or X2 and Y2. DX is probably too aggressive by itself
numberOfPriorsReferenced: -1, | ||
}; | ||
|
||
export const mgMLO = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you aren't using the view code matcher? See mammoDisplaySetSElectors
The code looks like:
const LCCSeriesMatchingRules = [
{
weight: 10,
attribute: 'ViewCode',
constraint: {
contains: 'SCT:399162004',
},
},
{
weight: 5,
attribute: 'PatientOrientation',
constraint: {
contains: 'L',
},
},
{
weight: 20,
attribute: 'SeriesDescription',
constraint: {
contains: 'L CC',
},
},
];
Could you start with hpMammo.ts and extend those hanging protocols? |
Context
solves #2019
Changes & Results
Just added cc and mlo hanging protocols
Testing
Just open some mammo studies with &hangingprotocolId=mgCC or mgMLO
Notes
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment