Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add simple multi-monitor support #4178

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wayfarer3130
Copy link
Contributor

Context

The ability to use more monitor space for viewing studies is quite useful for being able to compare current/prior or comparing various series.

Changes & Results

Added some basic navigation controls to the study browser (thumbnails list) to navigate the study to the specified one.

Testing

Launch the localhost url, OR an https URL with ?multimonitor=split or ?multimonitor=2
(use 2 only if you have two physical monitors)
Display a study which has several studies for the same MRN
Launch the study in basic test mode or in viewer mode
Use the study browser on the left hand side to launch studies into either the other window or the same window.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented May 27, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e08ea76
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/672cd8ce423b1b00081e5c8c
😎 Deploy Preview https://deploy-preview-4178--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit e08ea76
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/672cd8cef1637d00084a21ba
😎 Deploy Preview https://deploy-preview-4178--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130
Copy link
Contributor Author

In the starting phase, launch a study using multimonitor=split
This will show in the current window
Select the all button to show all studies for a patient, and click on the launch study button on the right hand side of the study list:
image

@wayfarer3130
Copy link
Contributor Author

This results in a second page being displayed with the specified study:
image

@wayfarer3130
Copy link
Contributor Author

You can then navigate either window from the 'all' studies in the study browser tab.

Study navigation currently refreshes the page, which loses the position on that page, plus any markup/annotations you have created. This is a temporary issue while the navigation is updated to use internal navigation to preserve data.

Copy link

cypress bot commented May 27, 2024

Viewers    Run #4396

Run Properties:  status check passed Passed #4396  •  git commit e08ea7684f: docs
Project Viewers
Branch Review feat/multi-monitor-take2
Run status status check passed Passed #4396
Run duration 05m 19s
Commit git commit e08ea7684f: docs
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant