-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the _validateRequiredSelectors method #4115
base: master
Are you sure you want to change the base?
Updating the _validateRequiredSelectors method #4115
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sedghi finally it is not a regression, just never been working before |
How can we test it? what was not working that is now after this PR working? |
Here is a sample of one of our custom rule : `import { utils } from '@ohif/core/src'; const { formatDate } = utils; export default function (displaySet, options) { const { studies } = options; if (studies.length <= 1) { let result = 0; const getTimeStamp = (dateString: string) => { The idea of this custom role is to have a rule in our HP saying "this viewport shall display a displayset that is earlier than the other known display set To do so we need to get the studies candidate so we can compute the timestamp difference and then apply a rule on this timestamp difference. |
Are we moving to shadcn components? If so, can we hold off on this? Or do you need it? |
I don't think there is a relation with the UI, it is usefull to apply custom matching rule relative to another display set candidate |
@salimkanoun I want to test this before merging. Could you please let me know where to add your code? Is it like a custom attribute? Can you perhaps provide me with the code for the full hanging protocol that I can run with studies that have priors? |
Do you guys still need this? |
Yes but didn't get the time to give you a minimal HP to reproduce why we need it, will do ASAP |
Context
Certain custom attributes require additional data.
Changes & Results
Updated the _validateRequiredSelectors method in the HangingProtocolService to pass additional props to the findMatch function, allowing for better handling of custom attributes.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment