Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up #118

Merged
merged 4 commits into from
Sep 21, 2024
Merged

up #118

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
^codecov\.yml$
^cran-comments\.md$
^CRAN-SUBMISSION$
^revdep$
3 changes: 0 additions & 3 deletions CRAN-SUBMISSION

This file was deleted.

3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Type: Package
Package: omock
Title: Creation of Mock Observational Medical Outcomes Partnership Common
Data Model
Version: 0.2.0
Version: 0.3.0
Authors@R: c(
person("Mike", "Du", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-9517-8834")),
Expand Down Expand Up @@ -46,4 +46,3 @@ Config/testthat/edition: 3
Encoding: UTF-8
RoxygenNote: 7.3.2
BugReports: https://github.com/ohdsi/omock/issues

2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# omock 0.3.0

# omock 0.2.0

# omock 0.1.0
Expand Down
2 changes: 1 addition & 1 deletion _pkgdown.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
url: https://oxford-pharmacoepi.github.io/omock/
url: https://ohdsi.github.io/omock/
template:
bootstrap: 5

Expand Down
7 changes: 7 additions & 0 deletions revdep/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
checks
library
checks.noindex
library.noindex
cloud.noindex
data.sqlite
*.html
58 changes: 58 additions & 0 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# Platform

|field |value |
|:--------|:-----------------------------------|
|version |R version 4.3.1 (2023-06-16 ucrt) |
|os |Windows 10 x64 (build 19045) |
|system |x86_64, mingw32 |
|ui |RStudio |
|language |(EN) |
|collate |English_United Kingdom.utf8 |
|ctype |English_United Kingdom.utf8 |
|tz |Europe/London |
|date |2024-09-17 |
|rstudio |2023.12.1+402 Ocean Storm (desktop) |
|pandoc |NA |

# Dependencies

|package |old |new |Δ |
|:------------|:------|:------|:--|
|omock |0.2.0 |0.2.0 |NA |
|blob |1.2.4 |1.2.4 |NA |
|cli |3.6.3 |3.6.3 |NA |
|cpp11 |0.5.0 |0.5.0 |NA |
|DBI |1.2.3 |1.2.3 |NA |
|dbplyr |2.5.0 |2.5.0 |NA |
|dplyr |1.1.4 |1.1.4 |NA |
|fansi |1.0.6 |1.0.6 |NA |
|generics |0.1.3 |0.1.3 |NA |
|glue |1.7.0 |1.7.0 |NA |
|lifecycle |1.0.4 |1.0.4 |NA |
|lubridate |1.9.3 |1.9.3 |NA |
|magrittr |2.0.3 |2.0.3 |NA |
|omopgenerics |0.3.0 |0.3.0 |NA |
|pillar |1.9.0 |1.9.0 |NA |
|pkgconfig |2.0.3 |2.0.3 |NA |
|purrr |1.0.2 |1.0.2 |NA |
|R6 |2.5.1 |2.5.1 |NA |
|rlang |1.1.4 |1.1.4 |NA |
|snakecase |0.11.1 |0.11.1 |NA |
|stringi |1.8.4 |1.8.4 |NA |
|stringr |1.5.1 |1.5.1 |NA |
|tibble |3.2.1 |3.2.1 |NA |
|tidyr |1.3.1 |1.3.1 |NA |
|tidyselect |1.2.1 |1.2.1 |NA |
|timechange |0.3.0 |0.3.0 |NA |
|utf8 |1.2.4 |1.2.4 |NA |
|vctrs |0.6.5 |0.6.5 |NA |
|withr |3.0.1 |3.0.1 |NA |

# Revdeps

## New problems (1)

|package |version |error |warning |note |
|:-----------------|:-------|:------|:-------|:----|
|[CohortConstructor](problems.md#cohortconstructor)|0.2.2 |__+1__ | | |

15 changes: 15 additions & 0 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
## revdepcheck results

We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 1 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* CohortConstructor
checking tests ...

1 change: 1 addition & 0 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*
39 changes: 39 additions & 0 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# CohortConstructor

<details>

* Version: 0.2.2
* GitHub: NA
* Source code: https://github.com/cran/CohortConstructor
* Date/Publication: 2024-07-31 09:50:02 UTC
* Number of recursive dependencies: 96

Run `revdepcheck::revdep_details(, "CohortConstructor")` for more info

</details>

## Newly broken

* checking tests ...
```
Running 'testthat.R'
ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
`expected`: TRUE
── Error ('test-unionCohorts.R:84:3'): gap and name works ──────────────────────
Error in `validateGeneratedCohortSet(cohort, soft = .softValidation)`: ! 3 observations outside observation period.
Backtrace:
1. └─omopgenerics::newCohortTable(cdm$cohort1) at test-unionCohorts.R:84:3
2. └─omopgenerics:::validateGeneratedCohortSet(cohort, soft = .softValidation)
3. └─omopgenerics::validateCohortArgument(...)
4. └─omopgenerics:::checkObservationPeriod(...)
5. └─cli::cli_abort(message = mes, call = call)
6. └─rlang::abort(...)

[ FAIL 41 | WARN 152 | SKIP 51 | PASS 192 ]
Error: Test failures
Execution halted
```