Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] web_widget_open_tab: add missing encoding on etree.tostring #2951

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][FIX] web_widget_open_tab: add missing encoding on etree.tostring #2951

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Oct 9, 2024 •
edited
Loading

Related: odoo/odoo#66866
@qrtl QT4867

@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for some specific nonn-english character [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-English characters. Oct 10, 2024
@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-English characters. [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-English characters Oct 10, 2024
@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-English characters [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-ASCII characters Oct 10, 2024
kanda999
kanda999 approved these changes Oct 10, 2024
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked as expected.

@AungKoKoLin1997 AungKoKoLin1997 changed the title [15.0][FIX] web_widget_open_tab: add encoding to etree to prevent IO_ENCODER error for certain non-ASCII characters [15.0][FIX] web_widget_open_tab: add missing encoding on etree.tostring Oct 15, 2024
yostashiro
yostashiro approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Should this be forward-ported?

@AungKoKoLin1997
Copy link
Contributor Author

Should this be forward-ported?

No, we didn't use etree.tostring inside _get_view() of odoo16.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

kanda999
kanda999 approved these changes Oct 16, 2024
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@AungKoKoLin1997
Copy link
Contributor Author

@oca/web-maintainers
Can we please get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AungKoKoLin1997 @OCA-git-bot @yostashiro @kanda999