[MIG] web disable export group: Migration to 17.0 #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] Automatically add root and admin to group [FIX] Website in manifest
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_disable_export_group/zh_CN/
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_disable_export_group/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_disable_export_group/es/
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_disable_export_group/pt/
… and the standard export
The previous adaptation was not correct due to: - The old XML-ID is already missing on post stage. - There's now only one group, so no need of all the imply + group assignation stuff like in previous version.
Currently translated at 100.0% (4 of 4 strings) Translation: web-15.0/web-15.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_disable_export_group/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_disable_export_group/
Currently translated at 100.0% (3 of 3 strings) Translation: web-16.0/web-16.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_disable_export_group/it/
chienandalu
suggested changes
Sep 3, 2024
| this.isExportXlsEnable = await this.userService.hasGroup( | ||
| patch(exportAllItem, { | ||
| async isDisplayed(env) { | ||
| const ExportEnable = super.isDisplayed(...arguments); |
There was a problem hiding this comment.
The super function is async, so you must call it with await
Suggested change
| const ExportEnable = super.isDisplayed(...arguments); | |
| const ExportEnable = await super.isDisplayed(...arguments); |
Comment on lines
+18
to
+21
| if (ExportXlsEnable) { | ||
| return ExportXlsEnable; | ||
| } | ||
| return ExportEnable; |
There was a problem hiding this comment.
It's the same:
Suggested change
| if (ExportXlsEnable) { | |
| return ExportXlsEnable; | |
| } | |
| return ExportEnable; | |
| return ExportXlsEnable || ExportEnable ; |
On the picky side, the usual convention is that local variables are declared with lower_case (snake_case) (e.g: export_xls_enable) and PascalCase is usually used for classes
There was a problem hiding this comment.
Maybe change the filename to export_all.esm.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.