Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] stock_weighing_threaded_print: New module #8

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[15.0][ADD] stock_weighing_threaded_print: New module #8

merged 1 commit into from
Sep 23, 2024

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Apr 24, 2024 •
edited
Loading

@chienandalu chienandalu force-pushed the 15.0-add-stock_weighing_threaded_print branch 3 times, most recently from ad2d204 to a17c62a Compare April 30, 2024 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Sep 1, 2024
@chienandalu chienandalu added no stale and removed stale labels Sep 2, 2024
@chienandalu
Copy link
Member Author

@sergio-teruel @carlosdauden this should be ready to merge

@pedrobaeza
Copy link
Member

Please rebase and avoid merge commits.

@chienandalu chienandalu force-pushed the 15.0-add-stock_weighing_threaded_print branch from 0ab1f5b to dd61d9d Compare September 23, 2024 07:33
@chienandalu
Copy link
Member Author

ups, sorry. done

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 23, 2024
pedrobaeza
pedrobaeza reviewed Sep 23, 2024
View reviewed changes
stock_weighing_threaded_print/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1 @@
Speed up label printing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not accurate. It should say that it allows to return the control of the user screen sooner, triggering the printing in a separate process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chienandalu chienandalu force-pushed the 15.0-add-stock_weighing_threaded_print branch from dd61d9d to 930f041 Compare September 23, 2024 10:58
pedrobaeza
pedrobaeza approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-8-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 324dca7 into OCA:15.0 Sep 23, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5f08adf. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-stock_weighing_threaded_print branch September 23, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosdauden carlosdauden carlosdauden approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no stale
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chienandalu @pedrobaeza @OCA-git-bot @sergio-teruel @carlosdauden