[15.0][ADD] mrp_weighing: Add module #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
changed the title
sergio-teruel
force-pushed
the
15.0-ADD-stock-weighing
branch
from
9415b74
to
913952d
Compare
sergio-teruel
force-pushed
the
15.0-ADD-stock-weighing
branch
2 times, most recently
from
dabba72
to
8952fb6
Compare
chienandalu
requested changes
Nov 6, 2024
mrp_weighing/models/stock_move.py
Outdated
Comment on lines
17
to
21
| @api.model | ||
| def _has_weigh_domain(self): | ||
| # All finished moves can be processed" | ||
| # TODO: Check with David | ||
| return [] |
There was a problem hiding this comment.
You're disabling the flag for any other workflow. If you don't want to filter by this criteria, don't do so in the mrp.production
Suggested change
| @api.model | |
| def _has_weigh_domain(self): | |
| # All finished moves can be processed" | |
| # TODO: Check with David | |
| return [] |
| def _compute_has_weighing_operations(self): | ||
| for mrp_production in self: | ||
| mrp_production.has_weighing_operations = ( | ||
| mrp_production.move_finished_ids.filtered("has_weight") |
There was a problem hiding this comment.
Suggested change
| mrp_production.move_finished_ids.filtered("has_weight") | |
| mrp_production.move_finished_ids |
| action = self.env["ir.actions.actions"]._for_xml_id( | ||
| "stock_weighing.weighing_operation_action" | ||
| ) | ||
| weight_moves = self.move_finished_ids.filtered("has_weight") |
There was a problem hiding this comment.
Suggested change
| weight_moves = self.move_finished_ids.filtered("has_weight") | |
| weight_moves = self.move_finished_ids |
sergio-teruel
force-pushed
the
15.0-ADD-stock-weighing
branch
from
8952fb6
to
be1ad38
Compare
|
@chienandalu Changes done |
carlosdauden
approved these changes
Nov 6, 2024
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7e91497. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT49525
ping @carlosdauden @chienandalu