[16.0][FIX] stock_picking_line_sequence model_create_multi #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model_create_multi warning
StefanRijnhart
requested changes
Feb 3, 2025
rousseldenis
reviewed
Feb 3, 2025
| # We do not reset the sequence if we are copying a complete picking | ||
| # or creating a backorder | ||
| if not self.env.context.get("keep_line_sequence", False): | ||
| move.picking_id._reset_sequence() |
There was a problem hiding this comment.
IMHO, this should be done once per picking. This should be grouped per picking.
|
Picked an improved version of this in the migration of this module to 18.0 in #1864 |
[FIX] stock_picking_line_sequence: model_create_multi
|
@andreampiovesana you should squash all commits together leaving just one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix warning @api.model_create_multi