[15.0][FIX] stock_return_request: Cache miss error when access to qty_returnable computed field on stock move #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,10 @@ class StockMove(models.Model): | |||
| def _compute_qty_returnable(self): | |||
| """Looks for chained returned moves to compute how much quantity | |||
| from the original can be returned""" | |||
| for move in self.filtered(lambda x: x.state not in ["draft", "cancel"]): | |||
There was a problem hiding this comment.
@sergio-teruel
To avoid multiple __set__ calls and n condition evaluations, do this:
self.update({"qty_returnable": 0.0})
There was a problem hiding this comment.
AFAIK, doing self.qty_returnable = 0 has the same performance against update, as there's only one value to set.
chienandalu
reviewed
Jan 21, 2025
| @@ -16,7 +16,10 @@ class StockMove(models.Model): | |||
| def _compute_qty_returnable(self): | |||
| """Looks for chained returned moves to compute how much quantity | |||
| from the original can be returned""" | |||
| for move in self.filtered(lambda x: x.state not in ["draft", "cancel"]): | |||
There was a problem hiding this comment.
Why not simply setting it to False at the beggining?
…nable computed field on stock move TT54590
sergio-teruel
force-pushed
the
15.0-FIX-stock_return_request-cache-miss-stock_move
branch
from
1a7ecbc to
fb5c128
Compare
|
changes done! |
marcelsavegnago
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT54590
ping @chienandalu @carlosdauden