[16.0][IMP] stock_move_line_lock_qty_done: prevent test cases from other modules from failing #1760
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume the test cases failed from |
yostashiro
reviewed
Nov 9, 2024
Comment on lines
14
to
17
| check_qty_done_change_allowed = ( | ||
| config["test_enable"] | ||
| and self.env.context.get("test_stock_move_line_lock_qty_done") | ||
| ) or not config["test_enable"] | ||
| if not check_qty_done_change_allowed: | ||
| return True |
There was a problem hiding this comment.
Shouldn't this suffice?
Suggested change
| check_qty_done_change_allowed = ( | |
| config["test_enable"] | |
| and self.env.context.get("test_stock_move_line_lock_qty_done") | |
| ) or not config["test_enable"] | |
| if not check_qty_done_change_allowed: | |
| return True | |
| if config["test_enable"] and not self.env.context.get("test_stock_move_line_lock_qty_done"): | |
| return True |
…dules from failing
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_move_line_lock_qty_done
branch
from
a356ecc
to
f863bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if we had other test cases that updated the done quantity after the transfer was done in our module, they would be blocked by
stock_move_line_lock_qty_done. This PR addresses that issue.@qrtl