Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] stock_picking_group_by_partner_by_carrier: Control the original_group_id propagation. #1751

Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Oct 28, 2024

Follows #1498 which was closed by ocabot. It works in production for months... should be nice to have-it merged

@lmignon
Copy link
Contributor Author

lmignon commented Oct 28, 2024

ping @jbaudoux @rousseldenis @sbejaoui @TDu

Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question on the migration script, otherwise looks good

…ed group

When merging an outgoing picking, update only the current moves with the new procurement group. This is required to ensure that an update of the quantity on a SO will be properly applied to all the picking chain through the run of stock rules.
… propagation configurable on stock rule.

In a multi steps delivery process, when you allow to group the moves linked to the same carrier and partner into the same shipping, it's important to be able to merge internal moves that could be pulled. This merge is only possible if the original_group_id is not propagated to the pulled moves. We add an option to disable the propagation on the stock.rule.
…p swap

When the grouping functionality is enabled. A new procurement group is created the first time a pick out is created as merged. Every time moves from a new group are added into the picking, the merged procurement is updated to link the new group. In this way, the group is never updated after its original creation
When a backorder is created from a merged picking, a new procurement group must be created to ensure that only original sale orders and procurement group from the remaining moves are linked to the backorder.
@lmignon lmignon force-pushed the 16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi branch from 17121f1 to 4c1f649 Compare October 30, 2024 08:15
@jbaudoux
Copy link
Contributor

@lmignon pre-commit to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants