Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_partner_note #1739

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 8, 2024

No description provided.

santostelmo and others added 15 commits October 8, 2024 18:12
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
@astirpe astirpe marked this pull request as ready for review October 8, 2024 16:25
Copy link

@scigghia scigghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some cosmetic suggestions to consider.

stock_picking_partner_note/models/res_config_settings.py Outdated Show resolved Hide resolved
stock_picking_partner_note/models/stock_picking_note.py Outdated Show resolved Hide resolved
stock_picking_partner_note/readme/CONFIGURE.md Outdated Show resolved Hide resolved
stock_picking_partner_note/readme/DESCRIPTION.md Outdated Show resolved Hide resolved
stock_picking_partner_note/models/stock_picking.py Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_partner_note

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2024
67 tasks
@astirpe astirpe force-pushed the 17_mig_stock_picking_partner_note branch from bf60c85 to 71b0a6e Compare January 15, 2025 20:19
@rousseldenis
Copy link
Contributor

@astirpe Thanks for this.

Could you improve your commit messages (you can keep separate commits) :

image

To reflect the real change (e.g.: [IMP] stock_picking_partner_note: Improving help messages or ...)

Thanks

astirpe and others added 2 commits January 16, 2025 09:24
Update stock_picking_partner_note/models/res_config_settings.py
Update stock_picking_partner_note/models/stock_picking_note.py
Update stock_picking_partner_note/readme/CONFIGURE.md
Update stock_picking_partner_note/readme/DESCRIPTION.md

Co-authored-by: Stefan Rijnhart (Opener) <[email protected]>
@astirpe astirpe force-pushed the 17_mig_stock_picking_partner_note branch from 62833b9 to 16ab42a Compare January 16, 2025 08:28
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking my suggestions!

@astirpe
Copy link
Member Author

astirpe commented Jan 16, 2025

@rousseldenis done, thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1739-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5fb9273 into OCA:17.0 Jan 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3221a9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants