Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_partner_note #1739

Open
wants to merge 15 commits into
base: 17.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 8, 2024

No description provided.

santostelmo and others added 15 commits October 8, 2024 18:12
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
Currently translated at 100.0% (28 of 28 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_partner_note
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_partner_note/it/
@astirpe astirpe marked this pull request as ready for review October 8, 2024 16:25
Copy link

@scigghia scigghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some cosmetic suggestions to consider.

Comment on lines +13 to +14
help="That must be activated if you want to prevent the update or deletion "
"of a note that is already in use by multiple contacts.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="That must be activated if you want to prevent the update or deletion "
"of a note that is already in use by multiple contacts.",
help="Prevent the update or deletion of a note that is already in use by "
"more than one contact.",

if len(partners) > 1:
raise UserError(
_(
"You cannot update or delete a note that linked to multiple"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"You cannot update or delete a note that linked to multiple"
"You cannot update or delete a note that is linked to multiple"

types will be shown in picking operations notes.
- On contacts add picking notes.

You can prevent users ot update or delete notes alredy in use by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can prevent users ot update or delete notes alredy in use by
You can prevent users from updating or deleting notes already in use by

@@ -0,0 +1,3 @@
Allow to record a message for the person in charge of order preparation
at the level of the customer, then have it as a note on the picking
transfer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transfer.
transfer. This reuses the existing note field on the picking and will make it read-only.

and n.note_type_id in ptnts
)
picking_notes = [
note.name.strip()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to apply odoo.tools.html_escape to the names, given that we're filling a html field with text content?

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_partner_note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants