Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] stock_rule_delays_in_workable_days #1729

Draft
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

alexandregaldeano
Copy link

@alexandregaldeano alexandregaldeano commented Sep 23, 2024

TODO

  • Translations
  • 100% test coverage (10 lines missing)
  • Live test on runboat
  • Code cleanup
    • Add demo data to simplify tests setup (and for usage within runboat)
  • Refactor into multiple modules, delete code that can be replaced by an existing module

@alexandregaldeano alexandregaldeano force-pushed the 14.0-add-stock-rule-delays-in-workable-days branch 23 times, most recently from d2e70c3 to 8d5de21 Compare September 25, 2024 14:58
@alexandregaldeano alexandregaldeano force-pushed the 14.0-add-stock-rule-delays-in-workable-days branch 3 times, most recently from cfe7c1d to 3a432d7 Compare September 26, 2024 13:58
@alexandregaldeano alexandregaldeano force-pushed the 14.0-add-stock-rule-delays-in-workable-days branch from 3a432d7 to aeeaf9c Compare September 26, 2024 14:08
@rousseldenis
Copy link
Contributor

@alexandregaldeano Still draft ?

@alexandregaldeano
Copy link
Author

@rousseldenis yes, I'll consider it reviewable when at least it works as expected on runboat and all tests/converage are ✅

I'm hoping to have this out of draft in a couple of days 🤞

@alexandregaldeano alexandregaldeano force-pushed the 14.0-add-stock-rule-delays-in-workable-days branch 5 times, most recently from d93aa31 to 399f4fc Compare October 1, 2024 11:04
@alexandregaldeano alexandregaldeano force-pushed the 14.0-add-stock-rule-delays-in-workable-days branch from 399f4fc to 67fa222 Compare October 7, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants