[14.0][FIX] stock_request: write method to update state in _compute_state

[kaynnan]

cc @marcelsavegnago @ForgeFlow @victoralmau @pedrobaeza

As described in issue #2066, after implementing the compute_state method in stock_request, a conflict arose with stock_request_tier_validation. When an SRO had tier validation active and pending reviews, it was confirmed without considering the tier validation status.

Upon analyzing the code, I opted to use item.write to set the status instead of simply assigning it with =. Following this change, the behavior aligned with expectations, where each SR and SRO operates individually according to their tier validation. Prior to this, if an SR was confirmed with an SRO having pending reviews, the action was executed while ignoring the pending reviews.

[WesleyOliveira98]

LGTM

[kaynnan]

ping @victoralmau @pedrobaeza

[pedrobaeza]

This is incorrect. A compute method must never write nor create any data. You can use dot notation or update method, but never write.

[kaynnan]

This is incorrect. A compute method must never write nor create any data. You can use dot notation or update method, but never write.

For now I'll leave this pull request in draft while I search for solutions to resolve the compute method conflict with tier.validation, because it's ignoring validation based on the status of SRO when using update or dot notation.