[17.0][MIG] stock_picking_report_valued: Migration to 17.0 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For avoiding problems if you don't have access to sales orders (stricter warehouse users, inter-company records...).
- This commit odoo/odoo@41bea41 breaked the inheritance.
In certain conditions of the DB (i.e. integration tests), previous code doesn't assure the price is going to be 100.
[FIX] stock_picking_report_valued: Wrong taxes amount if round globally (OCA#56) [FIX] stock_picking_report_valued: Remove round_method condition because don't apply here [FIX] stock_picking_report_valued: price_reduce is stored with product decimal precision [FIX] stock_picking_report_valued: division_by_zero when unrelated sale order [FIX] stock_picking_report_valued: Improve code [FIX] stock_picking_report_valued: Multiple taxes in sale line (WIP)
Currently translated at 76.9% (20 of 26 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_picking_report_valued/fr_FR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_picking_report_valued/
…ferences TT17492 TT26034 TT33957 TT34954
The fix in fac3997 didn't consider move lines without a linked sale line. That would end up in inconsistent calculations and even the original line rewriting. TT38863
- In standard report, Odoo always show qty_done
…ots in delivery slip
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/pt/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/fr/
Currently translated at 73.9% (17 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/fr_FR/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/fr/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/es/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/it/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/it/
Currently translated at 100.0% (23 of 23 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_valued Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_valued/it/
nguyenminhchien
commented
Jan 17, 2024
| <t t-if="o.valued and o.sale_id and o.move_line_ids and is_outgoing"> | ||
| <t t-if="o.state != 'done'"> | ||
| <th class="text-end"><strong>Qty Reserved</strong></th> | ||
| </t> |
There was a problem hiding this comment.
i removed this because the table stock_move_line_table was only shown when o.state == done.
nguyenminhchien
commented
Jan 17, 2024
| <td class="text-center"> | ||
| <span t-field="move_line.qty_done" /> | ||
| <span t-field="move_line.product_uom_id" /></td> | ||
| </t> |
There was a problem hiding this comment.
Because the new columns are added to the table stock_move_line_table which shown when o.state = done, so, we don't need these lines of code.
|
/ocabot migration stock_picking_report_valued |
gurneyalex
approved these changes
Jan 25, 2024
|
@nguyenminhchien can you add a note in the README file mentioning that this module includes the features from stock_picking_report_valued_delivery (maybe in a Changelog section) |
nguyenminhchien
force-pushed
the
17.0-mig-stock_picking_report_valued
branch
from
bcc061b to
df92eee
Compare
Added. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at fc25225. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: BSRD-711
I improve this module a bit to make it works with the column of HS Code (after installing the module
stock_delivery).It means that we don't need to migrate the module
stock_picking_report_valued_deliveryin version 17.0 anymore.Result:
Report has both Lot Number and HS Code
Report has Lot Number but not HS Code
Report has HS Code but not Lot Number
Report has no Lot Number nor HS Code
