Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] mail_chatter_company_tracking #1461

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

adasatorres
Copy link

@adasatorres adasatorres commented Oct 9, 2024

This add-on includes the company name in the email chatter tracking and filters tracking based on allowed companies.

@adasatorres adasatorres force-pushed the 14.0-add-mail_chatter_company_tracking branch 3 times, most recently from 7ab8744 to b8d200c Compare October 9, 2024 13:06
@Abimael1321
Copy link

Functionally reviewed. LGTM

@Yoana-RB
Copy link

LGTM!!

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great that way:
image
Please take a look at my comments regarding the dependencies. I’d like to know your thoughts on this. It’s true that by adding the module, we avoid duplicating the same logic, but without it, we make the module more independent. It's just a point and im not sure wich one should be the best approach. So LGTM

"license": "AGPL-3",
"category": "social",
"version": "14.0.1.0.0",
"depends": ["mail", "company_dependent_attribute"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this can be useful for understanding how the module works, but technically, it's not necessary. A good approach might be to include it in the README as a helpful optional feature that users can choose to install.

Suggested change
"depends": ["mail", "company_dependent_attribute"],
"depends": ["mail"],

mail_chatter_company_tracking/models/mail_message.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants