-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][14.0] auth_saml: Add FOR UPDATE NOWAIT clause to SAML provider query #716
Open
Ricardoalso
wants to merge
1
commit into
OCA:14.0
Choose a base branch
from
Ricardoalso:auth_saml_provider_locks
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricardoalso
force-pushed
the
auth_saml_provider_locks
branch
from
October 17, 2024 12:41
fec6c83
to
81014f5
Compare
gurneyalex
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the commit message:
- mention the other attempts with the locks, and the issues they caused
- explain the race condition we checked together this morning with 2 login attempts that will cause 2 updates of the idp_metadata in parallel
- explain how the fix is preventing this
gurneyalex
reviewed
Oct 17, 2024
Ricardoalso
force-pushed
the
auth_saml_provider_locks
branch
from
October 17, 2024 15:28
81014f5
to
607b03a
Compare
- Enhance concurrency handling when fetching SAML provider data - Prevent potential deadlocks by using NOWAIT - Ensure data consistency during high-traffic scenarios Previous attempt using the locking mechanisms self.env.cr.execute( "SELECT id FROM auth_saml_provider WHERE id in %s FOR UPDATE", (tuple(provider_ids),), ) led to increased latency and deadlocks under high load. We experienced race conditions where two simultaneous login attempts triggered parallel updates of the idp_metadata, leading to unreleased locks. The FOR UPDATE NOWAIT clause addresses this issue by: 1. Acquiring an exclusive lock on the row being updated 2. Failing fast if the lock cannot be acquired (NOWAIT) 3. Ensuring that only one transaction can update the idp_metadata at a time
Ricardoalso
force-pushed
the
auth_saml_provider_locks
branch
from
October 17, 2024 15:32
607b03a
to
f00a171
Compare
cyrilmanuel
approved these changes
Oct 22, 2024
cyrilmanuel
approved these changes
Oct 22, 2024
victorvermot
approved these changes
Oct 22, 2024
gurneyalex
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt using the locking mechanisms
led to increased latency and deadlocks under high load.
We experienced race conditions where two simultaneous login
attempts triggered parallel updates of the idp_metadata, leading to unreleased locks.
The FOR UPDATE NOWAIT clause addresses this issue by: