[18.0][MIG] sale_force_invoiced

[odooexperts-visioncode]

No description provided.

[rousseldenis]

/ocabot migration sale_force_invoiced

[rousseldenis]

this change should be in migration commit

[rousseldenis]

@odooexperts-visioncode Ok, I think you misunderstood what I wanted to say.

You should follow this :
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

The important part on the line with pre-commit stuff is the --no-verify option. Unless it will fail and ask you to change the version number. Pre-commit changes should stay in separate commit.

Then, you update the module version (and other changes maybe) and then you put them in the migration commit.

[odooexperts-visioncode]

@rousseldenis Currently, there are not any changes in the pre-commit run, only pylint Failure for the version.

As there are not any change in the pre-commit, I might commit with --allow-empty

So, should I push an empty commit initially or the Direct Migration commit will be okay?

[rousseldenis]

@rousseldenis Currently, there are not any changes in the pre-commit run, only pylint Failure for the version.

As there are not any change in the pre-commit, I might commit with --allow-empty

So, should I push an empty commit initially or the Direct Migration commit will be okay?

As I said, follow the procedure after running pre-commit run -a, do git commit -m "[IMP] $module: pre-commit auto fixes" --no-verify

[rousseldenis]

As there are not any change in the pre-commit, I might commit with --allow-empty

Ooooh, ok. So, it's ok as is

[odooexperts-visioncode]

@rousseldenis So, do I push 2 commits (1 empty and 1 migration) or just a single migration commit is okay?