[ADD][16.0] Sale Margin Update #3374
Conversation
There was a problem hiding this comment.
Hi @ljimenezsidoo great to see your contribution. You are proposing a new addon so I would prefer make a deeper description of PR's digging on the specific requirement is trying to fulfill, comparing maybe with standard behavior or whether it is possible with a functional approach to address the real issue. If You clarify those points I think will be more helpful to understand what is this about. Maybe U can tag me then. Thank U.
ljimenezsidoo
force-pushed
the
16.0-add_sale_margin_update
branch
from
c5e288e
to
d844045
Compare
FIX requested changes ADD test
ljimenezsidoo
force-pushed
the
16.0-add_sale_margin_update
branch
from
d844045
to
cf1e13b
Compare
|
This PR has the |
|
@ljimenezsidoo can U review mine in exchange #3380 ? |
| @@ -0,0 +1,38 @@ | |||
| ############################################################################### | |||
There was a problem hiding this comment.
You can adopt short licensing headers.
| @@ -0,0 +1,5 @@ | |||
| ############################################################################### | |||
| @@ -0,0 +1,19 @@ | |||
| ############################################################################### | |||
There was a problem hiding this comment.
This is not OCA guidelines. You can put here short license headers.
See this example: https://github.com/OCA/maintainer-tools/blob/master/template/module/models/model_name.py#L1
| "res_model": "recalculate.price.margin", | ||
| "view_mode": "form", | ||
| "target": "new", | ||
| "context": {"default_line_id": self.id}, |
There was a problem hiding this comment.
You should reuse current context.
|
|
||
|
|
||
| class TestRecalculatePriceMargin(TransactionCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
Use classmethod instead, for performance reasons.
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestRecalculatePriceMargin(TransactionCase): |
There was a problem hiding this comment.
You can use this instead: https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/tests/common.py#L19
for performances reasons.
| required=True, | ||
| ) | ||
| line_id = fields.Many2one( | ||
| "sale.order.line", |
There was a problem hiding this comment.
| "sale.order.line", | |
| "sale.order.line", | |
| ondelete="cascade" |
| "sale.order.line", | ||
| ) | ||
| order_id = fields.Many2one( | ||
| "sale.order", |
There was a problem hiding this comment.
| "sale.order", | |
| "sale.order", | |
| ondelete="cascade" |
This module adds a wizard that enables users to recalculate the unit price of products on a sale order line based on a specified margin percentage. It allows recalculating the sale price dynamically to ensure the desired profit margin is achieved.
Margin-based Price Adjustment: Users can specify a margin percentage to calculate and set the product's sale price according to that margin.
Negative and High Margin Constraints: The module includes validation to prevent negative margins and margins equal to or greater than 100%.