Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] sale_invoice_plan: recompute invoice plan table #2543

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[15.0][FIX] sale_invoice_plan: recompute invoice plan table #2543

merged 1 commit into from
Dec 20, 2023

Conversation

ps-tubtim
Copy link
Member

This pull request was used to recompute Amount in the invoice plan table.
Amount in the invoice plan table is computed from the sum of the untaxed amount.

@OCA-git-bot
Copy link
Contributor

Hi @kittiu,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added this to the 15.0 milestone Jun 14, 2023
rousseldenis
rousseldenis reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ps-tubtim Maybe a little test for deposit product ?

@ps-tubtim ps-tubtim force-pushed the 15.0-enh-sale_invoice_plan-create_invoice branch from 8c6617f to fb258b5 Compare December 20, 2023 02:57
@ps-tubtim ps-tubtim force-pushed the 15.0-enh-sale_invoice_plan-create_invoice branch from fb258b5 to 4c157f0 Compare December 20, 2023 05:02
@kittiu
Copy link
Member

kittiu commented Dec 20, 2023

Functional tested works well.

@kittiu kittiu mentioned this pull request Dec 20, 2023
Closed
@kittiu
Copy link
Member

kittiu commented Dec 20, 2023

Note: this fix seem to be related to the problem discussing in #2438

@dreispt
Copy link
Member

dreispt commented Dec 20, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2543-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit e9e44f3 into OCA:15.0 Dec 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dad3c90. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@dreispt dreispt dreispt approved these changes

@kittiu kittiu kittiu approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ps-tubtim @OCA-git-bot @kittiu @dreispt @rousseldenis