[15.0][FIX] purchase_delivery_split_date: prevent error when adding a PO line on confirmed POs #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purchase order line on a different delivery date on confirmed POs For example: use the purchase request module to add a new line on an existing PO
| @@ -132,7 +132,7 @@ def _check_split_pickings(self): | |||
| continue | |||
| if ( | |||
| move.picking_id.scheduled_date.date() != date_key | |||
| or pickings_by_date[date_key] != move.picking_id | |||
| or pickings_by_date.get(date_key, []) != move.picking_id | |||
There was a problem hiding this comment.
Just a nitpick: I find using a list as a default value confusing and I would not be surprised if this comparison was going to give a TypeError at some point. You can just leave it out, because comparing with None (get's default) is at least just as valid.
In [2]: picking
Out[2]: stock.picking(1,)
In [3]: picking != []
Out[3]: True
In [4]: picking != None
Out[4]: True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reproduced it by using the purchase request module to add a new line on an existing PO using the flag:
"Merge on PO lines with equal Scheduled Date"
cc @ForgeFlow