-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] purchase_manual_delivery #2417
Open
StefanRijnhart
wants to merge
49
commits into
OCA:17.0
Choose a base branch
from
StefanRijnhart:17.0-mig-purchase_manual_delivery
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] purchase_manual_delivery #2417
StefanRijnhart
wants to merge
49
commits into
OCA:17.0
from
StefanRijnhart:17.0-mig-purchase_manual_delivery
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] ability to change destination location in wizard
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
2 times, most recently
from
September 26, 2024 12:45
21020f0
to
a35c706
Compare
Currently translated at 100.0% (56 of 56 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_manual_delivery Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_manual_delivery/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_manual_delivery Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_manual_delivery/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_manual_delivery Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_manual_delivery/
Currently translated at 100.0% (65 of 65 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_manual_delivery Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_manual_delivery/it/
Fixed issues when uom_id and uom_po_id of a product are different. - Comparison for Purchase Order Line pending to receive now uses the product quantity that uses the uom of the Purchase Order Line. - When creating the Stock Move the quantity is now computed into the uom of the Stock Move
Fixes the following 2 errors: - When the product_uom_qty changes the recompute is not triggered - In case that existing_qty > product_uom_qty the line should not be pending_to_receive
…utton when manual_delivery is False
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 12:52
a35c706
to
9cae351
Compare
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 13:06
9cae351
to
b46080b
Compare
Purchase Order Lines that are pending to receive are not considered for stock forecast. Thus, the manual and automatic reordering of products can be done despite having already create a Purchase Order and surpassing the max quantity. Confirmed Purchase Orders with pending to receive Purchase Order Lines are now considered at the forecast and the forecast report.
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 14:02
b46080b
to
11b8c42
Compare
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 14:06
11b8c42
to
3a1ae92
Compare
This was referenced Sep 26, 2024
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 15:06
d955aa6
to
e60fde5
Compare
To prevent interference from other modules. In this case, there is a purchase order from Odoo's demo data in a confirmed state but without a picking for the product. The missing picking causes purchase_manual_delivery to include the PO line's quantity in the forecasted quantity of the product. This prevents the procurement to go through in TestPurchaseRequestProcurement.test_orderpoint. ``` 2024-09-26 14:16:17,327 269 ERROR odoo odoo.addons.purchase_request.tests.test_purchase_request_procurement: FAIL: TestPurchaseRequestProcurement.test_orderpoint Traceback (most recent call last): File "/__w/purchase-workflow/purchase-workflow/purchase_request/tests/test_purchase_request_procurement.py", line 81, in test_orderpoint self.assertEqual( AssertionError: 0.0 != 5 ```
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 26, 2024 15:07
e60fde5
to
58e248d
Compare
astirpe
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you also for including #2189
/ocabot migration purchase_manual_delivery |
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 30, 2024 14:48
f71b06b
to
c8ed853
Compare
…' stock moves Rename existing_qty to qty_in_receipt. It now reflects the quantity for which there are pending stock moves and no longer includes the quantities of 'done' stock moves. Co-authored-by: Cas Vissers <[email protected]>
StefanRijnhart
force-pushed
the
17.0-mig-purchase_manual_delivery
branch
from
September 30, 2024 14:49
c8ed853
to
6dbfa62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #2189, #2383
We're also proposing a small data model change. Previously, purchase order line's
existing_qty
included quantities from done stock moves. We're renaming the field toqty_in_receipt
and changing the semantics to only include quanties from pending stock moves. Thepending_to_receive
will still be set under the same condition: if the ordered quantity is larger than the received quantity plus the quantities on pending stock moves. Data migration is included.