Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_variant_name #347

Open
wants to merge 9 commits into
base: 17.0
Choose a base branch
from

Conversation

Deriman-Alonso
Copy link
Member

Standart migration.

@Deriman-Alonso Deriman-Alonso mentioned this pull request Apr 19, 2024
6 tasks
@Christian-RB
Copy link

@Deriman-Alonso Could you separate the pre-commit stuff and the migration changes on different commits? Thanks!

@Deriman-Alonso
Copy link
Member Author

@Christian-RB Done 👍.

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review
LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
easy code review.
something seems to be wrong with the runboat, can't be tested on this one

@flotho
Copy link
Member

flotho commented Jun 24, 2024

Hi @Deriman-Alonso , could you rebase ?
Regards

@rousseldenis
Copy link

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 17.0.

@OCA-git-bot OCA-git-bot force-pushed the 17.0-mig-product_variant_name branch from 7223375 to 45d5a8f Compare June 24, 2024 10:28
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants