[16.0][IMP] product_supplierinfo_import_by_barcode: To product_supplierinfo_import

[juancarlosonate-tecnativa]

• Add supplier in templates.
• Allow matching at the template level by product.template char fields
• Add the option to update only existing supplierinfos without creating new ones.
• Add option at the template level, which groups records in the view by updated and non-updated after the import process.

@Tecnativa TT55210
@pedrobaeza @chienandalu

[juancarlosonate-tecnativa]

ping @pedrobaeza @chienandalu can you take a look? thx!

[pedrobaeza]

You shouldn't rewrite the whole commit history for renaming it. That should be done when migrating to upper versions. Now, you just need to add the new feature on top in one commit, respecting the name AFAIK (not sure what you agreed with @chienandalu though, but for sure renaming this way not).

Please perform that change ASAP.

[juancarlosonate-tecnativa]

You shouldn't rewrite the whole commit history for renaming it. That should be done when migrating to upper versions. Now, you just need to add the new feature on top in one commit, respecting the name AFAIK (not sure what you agreed with @chienandalu though, but for sure renaming this way not).

Please perform that change ASAP.

Alright, i thought this was the way to do it, anyway, i will wait for @chienandalu comments before proceeding, thanks!

[chienandalu]

You shouldn't rewrite the whole commit history for renaming it. That should be done when migrating to upper versions. Now, you just need to add the new feature on top in one commit, respecting the name AFAIK (not sure what you agreed with @chienandalu though, but for sure renaming this way not).
Please perform that change ASAP.

Alright, i thought this was the way to do it, anyway, i will wait for @chienandalu comments before proceeding, thanks!

I think we agreed to avoid renaming the module in this version and do so in the future migration as the less problematic way to proceed.

[chienandalu]

Overall look in the good path :D

Some changes needed though:

[juancarlosonate-tecnativa]

ping @chienandalu

[chienandalu]

I'm testing in runboat with the complex spreadsheet. It is detected buy when imported, the following error ocurrs:

File "/mnt/data/odoo-addons-dir/product_supplierinfo_import_by_barcode/wizards/product_supplierinfo_import.py", line 247, in action_import_file
) = self._update_create_supplierinfo_data(parsed_data)
File "/mnt/data/odoo-addons-dir/product_supplierinfo_import_by_barcode/wizards/product_supplierinfo_import.py", line 175, in _update_create_supplierinfo_data
supplier_infos += self._create_new_supplierinfo(
File "/mnt/data/odoo-addons-dir/product_supplierinfo_import_by_barcode/wizards/product_supplierinfo_import.py", line 236, in _create_new_supplierinfo
product_supplierinfo.write(self._prepare_supplierinfo_values(row_data))
File "/mnt/data/odoo-addons-dir/product_supplierinfo_import_by_barcode/wizards/product_supplierinfo_import.py", line 121, in _prepare_supplierinfo_values
{
File "/mnt/data/odoo-addons-dir/product_supplierinfo_import_by_barcode/wizards/product_supplierinfo_import.py", line 122, in
tl.field_id.name: row_data[tl.header_name]
KeyError: 'Final\n'

[juancarlosonate-tecnativa]

@chienandalu it seems to be due to these blank lines

[chienandalu]

@chienandalu it seems to be due to these blank lines

Yes, it's deliberated. As when the user copy/pastes from the excel headers the could be pasting those line feeds as well it it was like that in the original.

That case was working before, if a don't remember wrong (and indeed the template is detected), do you know why it isn't now?

[chienandalu]

Let's try to avoid importing this rows. Add a method that checks if the columns corresponding to importing fields have any content and ignore the ones that doesn't.

[chienandalu]

Suggested change

	_("%(code)s ((product imported))", code=search_value),
	_("%(code)s (product imported)", code=search_value),

[juancarlosonate-tecnativa]

take a look at this and let me know what you think, don't like it much, but i think it works well

[chienandalu]

A simpler implementation

    def _prepare_supplierinfo_values(self, row_data):
        """Overridable hook method so we can inject general wizard values"""
        values = {
            tl.field_id.name: row_data.get(
                self._parse_header([tl.header_name])[0], ""
            )
            for tl in self.template_id.template_line_ids
            if tl.field_id
        }
        # Avoid rows where there's no information given
        all_values_with_content = all([x not in {None, ""} for x in values.values()])
        if not all_values_with_content:
            return
        values.update({
            "delay": self.delay,
            "date_start": self.date_start,
        })
        return values

[chienandalu]

simply return is the same as return None. Anyway, prefer to return always the same datatype. For example, return self.env["product.product"]. It makes it potentially easier to deal with it the method later in different scenarios.

[chienandalu]

Same here return self.env["product.supplierinfo"]