-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_pricelist_alternative: Migration to 18.0 #1863
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] product_pricelist_alternative: Migration to 18.0 #1863
Conversation
Currently translated at 100.0% (11 of 11 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_alternative Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_alternative/it/
…th based formula pricelist
Currently translated at 100.0% (13 of 13 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_alternative Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_alternative/it/
14cc0b5
to
905bc92
Compare
<field name="alternative_pricelist_policy" /> | ||
</xpath> | ||
<xpath | ||
expr="//page[@name='pricelist_rules']/field[@name='item_ids']/tree[@groups='product.group_sale_pricelist']/field[@name='name']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: groups="product.group_sale_pricelist"
is removed in 18.0.
Only a single <list>
remain whereas before two elements existed
0e719b2
to
441e62f
Compare
@santostelmo would you mind reviewing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
@grindtildeath would you mind reviewing this PR? 🙏 |
/ocabot migration product_pricelist_alternative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't agree on sale
dependency addition
At first glance, product dependency is enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it depend of product
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, drop the dependency and keep your extra code, no need for a glue module
5745b37
to
6dda360
Compare
6dda360
to
5486e66
Compare
|
Hello @rousseldenis |
This PR adds the context key
force_price_recomputation
, used insale
'ssale.order::_recompute_prices()
, triggered byaction_update_prices()
button that recomputes the unit price of all products based on the new pricelist.This is done in order to correctly select the alternative pricelist when changing the pricelist on a SO and updating the prices.
TODO: