[14.0][IMP] mis_builder_budget: drilldown: default budget & account #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
norlinhenrik
force-pushed
the
14.0-imp-mis_builder_budget-drilldown
branch
from
85e222a
to
b09a487
Compare
sbidoul
reviewed
Apr 29, 2024
| @@ -944,6 +944,8 @@ def drilldown(self, arg): | |||
| account_id, | |||
| ) | |||
| domain.extend(period._get_additional_move_line_filter()) | |||
| context = arg.get("context") or {} | |||
There was a problem hiding this comment.
This PR sounds interesting, but why looking for the context in arg instead of self.env.context ?
There was a problem hiding this comment.
Sorry for late reply. I get the context now from frozendict self.env.context.
sbidoul
reviewed
Apr 29, 2024
| arg["context"] = { | ||
| "default_budget_id": period.source_mis_budget_by_account_id.id, | ||
| "default_account_id": arg.get("account_id"), | ||
| } |
There was a problem hiding this comment.
Mutating arg here does not sound right. Could this be propagated with with_context ?
norlinhenrik
force-pushed
the
14.0-imp-mis_builder_budget-drilldown
branch
from
b09a487
to
0586b76
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drilldown to "Budget By Account Items": Pass default budget and default account.
If the budget allows items overlap, one can create new budget items in the drilldown.