Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mis_builder: correctly compute context in mis_report_widget #585

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

IT-Ideas
Copy link

@IT-Ideas IT-Ideas commented Nov 15, 2023

This PR ensures that the context used by the mis_report_widget widget RPC calls is correctly computed.

Previously using the mis_analytic_domain context key was useless as not taken into account in the widget.

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sbidoul
Copy link
Member

sbidoul commented Nov 15, 2023

This seems to break the filter. On runboat, I tried this filter with the demo report

image

And I got this error

image

The same works on 16.0

@IT-Ideas IT-Ideas force-pushed the 16.0-mis-builder-fix-mis_analytic_domain-lst branch from 091c1fb to ff1ea82 Compare November 15, 2023 20:38
@IT-Ideas
Copy link
Author

IT-Ideas commented Nov 15, 2023

This seems to break the filter. On runboat, I tried this filter with the demo report

image

And I got this error

image

The same works on 16.0

Oops Indeed I forgot to return the Domain as a list and not as an ast Domain.

@IT-Ideas
Copy link
Author

@sbidoul it should be ok now 🙂

@sbidoul
Copy link
Member

sbidoul commented Nov 17, 2023

Yes, I tested, this works fine now.

Wondering if the search bar widget is capable of loading and displaying the value from the context.

@IT-Ideas
Copy link
Author

Yes, I tested, this works fine now.

Wondering if the search bar widget is capable of loading and displaying the value from the context.

I'll have a look and also about the fact that the filters would be returned to this view when modified on the drilldown one. I am wondering whether we could use the globalstate in order to achieve this but I need a bit more of research.
Or in another PR? Let me know 🙂

@sbidoul
Copy link
Member

sbidoul commented Nov 17, 2023

This can be another PR, no urgency.

@IT-Ideas
Copy link
Author

@sbidoul Actually, the domain cannot be displayed as this does not correspond to a filter, but if filters are set in the context we should indeed use them. I do not know if it is the case. I'll have a look.

This commit ensure that the context used by the `mis_report_widget`
widget RPC calls is correctly computed.

Previously using the `mis_analytic_domain` context key was useless
as not taken into account in the widget.
@IT-Ideas IT-Ideas force-pushed the 16.0-mis-builder-fix-mis_analytic_domain-lst branch from ff1ea82 to 46d9440 Compare December 27, 2023 13:56
@IT-Ideas
Copy link
Author

Rebased

@sbidoul sbidoul added the 16.0 label May 10, 2024
@sbidoul sbidoul changed the title [FIX] mis_builder: correctly compute context in mis_report_widget [16.0][FIX] mis_builder: correctly compute context in mis_report_widget May 10, 2024
Copy link

github-actions bot commented Sep 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
@github-actions github-actions bot closed this Oct 13, 2024
@sbidoul sbidoul reopened this Oct 13, 2024
@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants