-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] mis_builder: correctly compute context in mis_report_widget #585
base: 16.0
Are you sure you want to change the base?
[16.0][FIX] mis_builder: correctly compute context in mis_report_widget #585
Conversation
Hi @sbidoul, |
091c1fb
to
ff1ea82
Compare
@sbidoul it should be ok now 🙂 |
Yes, I tested, this works fine now. Wondering if the search bar widget is capable of loading and displaying the value from the context. |
I'll have a look and also about the fact that the filters would be returned to this view when modified on the drilldown one. I am wondering whether we could use the globalstate in order to achieve this but I need a bit more of research. |
This can be another PR, no urgency. |
@sbidoul Actually, the domain cannot be displayed as this does not correspond to a filter, but if filters are set in the context we should indeed use them. I do not know if it is the case. I'll have a look. |
This commit ensure that the context used by the `mis_report_widget` widget RPC calls is correctly computed. Previously using the `mis_analytic_domain` context key was useless as not taken into account in the widget.
ff1ea82
to
46d9440
Compare
Rebased |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi @sbidoul, |
This PR ensures that the context used by the
mis_report_widget
widget RPC calls is correctly computed.Previously using the
mis_analytic_domain
context key was useless as not taken into account in the widget.