Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mrp_lot_number_propagation #1299

Open
wants to merge 26 commits into
base: 17.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jul 4, 2024

No description provided.

sebalix and others added 25 commits July 4, 2024 10:21
When defining a single BOM for a product template having multiple
product variants, we can have different components where the lot
number must be propagated for different product variants.

Therefore we need to allow to mark multiple BOM line with
propagate_lot_number, and to avoid complicating the check function
on the BOM lines, we ensure at the manufacturing order confirmation
that only a single component is set to propagate its lot number.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/
Currently translated at 100.0% (23 of 23 strings)

Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/
Currently translated at 100.0% (24 of 24 strings)

Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Currently translated at 100.0% (24 of 24 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_lot_number_propagation
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_lot_number_propagation/es/
@astirpe astirpe marked this pull request as ready for review July 4, 2024 08:35
@astirpe astirpe force-pushed the 17_mig_mrp_lot_number_propagation branch 2 times, most recently from e8c931b to c02c060 Compare July 7, 2024 12:45
for order in self:
if (
order.is_lot_number_propagated
and "lot_producing_id" in vals

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe if lot_producing_id is False we should not raise the error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CasVissers-360ERP done here c62f997 could you check?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx resolved.

@bosd
Copy link

bosd commented Aug 20, 2024

@astirpe Can you please squash your last commit?

@astirpe astirpe force-pushed the 17_mig_mrp_lot_number_propagation branch from c62f997 to bcbb8bb Compare August 20, 2024 18:23
@astirpe
Copy link
Member Author

astirpe commented Aug 20, 2024

@bosd squashed, thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link

bosd commented Sep 25, 2024

Seems like the @OCA-git-bot is still on holiday, as this one carries the approved label and can be merged.

Just noticed the "confusing" naming of this module.
Technical name is lot propagation, but the title reads serial propagation.
image

@Highcooley
Copy link

Seems like the @OCA-git-bot is still on holiday, as this one carries the approved label and can be merged.

Just noticed the "confusing" naming of this module. Technical name is lot propagation, but the title reads serial propagation. image

The idea was to leave this option open in the technical name to also propagate LOT numbers in the future and not just SN. Also Odoo std naming only talks about LOT and not about SN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.