[17.0][MIG] maintenance_plan: Migration to 17.0 #414

FernandoRomera · 2024-07-23T13:04:09Z

No description provided.

… equipment maintenance team is not filled [ADD] icon.png

[UPD] Update maintenance_plan.pot

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/ [UPD] README.rst

…nt company maintenance_plan 12.0.1.1.0

[ADD] instructions and notes to Plan - Add menus for maintenance plans. - Set active button on maintenance plans. improve navigation to maintenance plans. [ADD] post-migration script

[UPD] Update maintenance_plan.pot [UPD] README.rst maintenance_plan 12.0.3.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/

[UPD] Update maintenance_plan.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/

Currently translated at 98.4% (63 of 64 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/

[UPD] Update maintenance_plan.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/

[UPD] Update maintenance_plan.pot maintenance_plan 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/ pre-commit update

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/

…patible. includes migration scripts

[UPD] Update maintenance_plan.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-13.0/maintenance-13.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_plan/

[UPD] Update maintenance_plan.pot [UPD] README.rst

Currently translated at 100.0% (69 of 69 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_plan/it/

* Use latest request_date both for done and todo searches. * When there is a latest done apply interval Co-authored-by: Lois Rilo <[email protected]> Co-authored-by: LoisRForgeFlow <[email protected]> maintenance_plan 14.0.1.0.1

Currently translated at 100.0% (69 of 69 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_plan/it/

* only consider request after the start maintenance date. * todo request ordered asc. * add more tests. maintenance_plan 14.0.1.0.2

FernandoRomera · 2024-08-07T10:09:58Z

@pedrobaeza @astirpe @etobella
Can you merge this PR, please?

pedrobaeza · 2024-08-07T11:35:45Z

A PSC or maintainer should confirm, like @etobella

etobella · 2024-08-07T22:03:10Z

maintenance_plan/__manifest__.py

    "author": "Camptocamp SA, ForgeFlow, Odoo Community Association (OCA)",
    "license": "AGPL-3",
    "category": "Maintenance",
    "website": "https://github.com/OCA/maintenance",
    "images": [],
-    "depends": ["base_maintenance"],
+    "depends": ["base_maintenance", "maintenance"],


I think maintenance is not required (base_maintenance depends on it)

https://github.com/OCA/maintenance/blob/17.0/base_maintenance/__manifest__.py#L12

Sorry, my mistake.

@etobella
Done.

etobella · 2024-08-07T22:03:14Z

maintenance_plan/hooks.py

@@ -23,17 +21,17 @@ def post_init_hook(cr, registry):

        for equipment in equipments:
            request = equipment.maintenance_ids.filtered(
-                lambda r: r.maintenance_type == "preventive"
+                lambda r, equipment=equipment: r.maintenance_type == "preventive"


Why this change?

B023 Function definition does not bind loop variable `equipment

https://docs.astral.sh/ruff/rules/function-uses-loop-variable/`

I see, it is a new requirement from ruff 👍

OCA-git-bot · 2024-08-08T06:14:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella · 2024-08-08T06:31:56Z

/ocabot merge nobump

OCA-git-bot · 2024-08-08T06:32:05Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-414-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-08T06:36:25Z

Congratulations, your PR was merged at 34b68d6. Thanks a lot for contributing to OCA. ❤️

victoralmau · 2024-11-06T13:09:12Z

Analyzing the maintenance module in v17 to add the migration script to OpenUpgrade I see that what is indicated here #414 (comment) is not exactly correct, because there is a recurrence field (recurring_maintenance and extra fields).

When creating now a request of preventive type and set recurrence (7 days for example), when the status is changed to one defined as “completed” (done field) a new request will be created (copy) with the corresponding date (schedule_date) https://github.com/odoo/odoo/blob/17.0/addons/maintenance/models/maintenance.py#L337 and in the new one we can maintain that recurrence, change it, etc (the corresponding activity is also added).

Having clarified the above I am not sure that this module is necessary. I comment this because the approach of the migration script will be different (define the corresponding data to use the odoo recurrence or use this module).

victoralmau · 2025-01-15T08:40:05Z

What do you think about my previous comment (OpenUpgrade scripts will depend on it because maybe this module is not necessary)? Ping @carlos-lopez-tecnativa

carlos-lopez-tecnativa

What do you think about my previous comment (OpenUpgrade scripts will depend on it because maybe this module is not necessary)? Ping @carlos-lopez-tecnativa

Thanks for the ping, @victoralmau. I tested this module and have some observations related to its migration.

Regarding recurrency, I believe this module provides a functionality that Odoo does not currently have—the ability to create maintenance requests in advance based on the Planning Horizon. In Odoo, you can only create the next maintenance request when the current one moves to a stage marked as "Done." However, for preventive maintenance in some contexts, it's necessary to generate all future maintenance requests in advance.

I think this module is still valuable but could benefit from some enhancements. For instance, it would be helpful if all maintenance requests related to the recurrency were visible within the maintenance.request form view, similar to how related tasks are displayed in project.task.

What do you think about this approach?

carlos-lopez-tecnativa · 2025-01-15T11:12:07Z

maintenance_plan/views/maintenance_plan_views.xml

+        <field name="context">{
+            'default_maintenance_plan_id': id,
+        }</field>
+        <field name="domain">[('maintenance_plan_id', '=', id)]</field>


carlos-lopez-tecnativa · 2025-01-15T11:15:55Z

maintenance_plan/models/maintenance_plan.py

+    def name_get(self):
+        result = []
+        for plan in self:
+            result.append(
+                (
+                    plan.id,
+                    plan.name
+                    or _(
+                        "Unnamed %(kind)s plan (%(eqpmt)s)",
+                        kind=plan.maintenance_kind_id.name or "",
+                        eqpmt=plan.equipment_id.name,
+                    ),
+                )
+            )
+        return result


Not blocking, but this can be replaced by _compute_display_name according to the migration guidelines.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

carlos-lopez-tecnativa · 2025-01-15T11:38:21Z

Please let me know the progress on this module's evolution. I plan to start the migration of the maintenance_plan_employee module, which depends on this one. @pedrobaeza

pedrobaeza · 2025-01-15T11:56:50Z

@carlos-lopez-tecnativa do the PR improving this module for not getting blocked.

victoralmau · 2025-02-19T12:08:50Z

My conclusions in summary after discussing it with my colleague @carlos-lopez-tecnativa

1- Keep the OCA module

Pros:

Previous users still work with the same approach.
All stock requests for a plan are already created.
No change in Openupgrade is required ([17.0][OU-ADD] maintenance: Migration scripts OpenUpgrade#4654).

Cons:

We are not taking advantage of the approach (fields) of recurrence in requests, causing confusion for whoever uses them and/or when they discover it.
We are adding code (and the module itself) maintenance_plan that core has already contemplated otherwise.
It is necessary to make change in Openupgrade [17.0][OU-ADD] maintenance: Migration scripts OpenUpgrade#4654

2- Do NOT use the OCA module

Pros:

No inconvenience for users who did not know it until now.
You can create recurrences (plans) from the first request.
Not all future requests are created at once, the next one will be created when the previous one is finished (more flexibility in the change of recurrence along the “plan”).
Removes code to maintain (maintenance_plan).

Cons:

Not all plan requests are created (only for users who already used it previously, in which case an OCA module could be created that by means of a button on the requests allows to create all future requests avoiding/confirming that on completion it will not create the next one).
Migration scripts in OpenUpgrade to adapt plans to linked stock requests and corresponding recurrence fields. Possible discussion if future uninitiated requests need to be deleted (to avoid confusion) (as they will be created when the next one is finalized).

Having clarified all this, I am of the opinion that the maintenance_plan module should be removed (having analyzed this before migrating it) and focus it towards core usage, applying the corresponding changes in Openupgrade at OCA/OpenUpgrade#4654.

Ping @pedrobaeza

pedrobaeza · 2025-02-19T15:07:53Z

OK then on stop using this module. Let's do the OU thing, and we can drop in this module a deprecated message in the README.

OCA#414 (comment)

grindtildeath and others added 30 commits July 23, 2024 14:44

[ADD] maintenance_plan module (OCA#2)

d296e6c

[FIX] maintenance_plan: README try me on runbot link

9b9813f

[MIG] maintenance_plan: Migration to 11.0

225fde2

[FIX] maintenance_plan: prevent preventive request cron crashing when…

95edee4

… equipment maintenance team is not filled [ADD] icon.png

[MIG] maintenance_plan: Migration to 12.0

0a2b3ea

[UPD] Update maintenance_plan.pot

Added translation using Weblate (Spanish)

ac937bf

Translated using Weblate (Spanish)

bcb0fcf

Currently translated at 100.0% (30 of 30 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/ [UPD] README.rst

Added translation using Weblate (Chinese (Simplified))

fd716aa

[FIX] maintenance_plan: cron generated request should inherit equipme…

f795f91

…nt company maintenance_plan 12.0.1.1.0

[FIX] maintenance_plan: next_maintenance_date should be stored

8a9569b

[12.0][IMP] maintenance_plan

10cd585

[ADD] instructions and notes to Plan - Add menus for maintenance plans. - Set active button on maintenance plans. improve navigation to maintenance plans. [ADD] post-migration script

[11.0][IMP] maintenance_plan: Return the created requests

bc4d4fa

[12.0][FIX] maintenance_project_plan

ea14a88

[12.0][FIX] default equipment_id in plans

d0ab0fe

Translated using Weblate (Spanish)

39b8a82

Currently translated at 98.4% (63 of 64 strings) Translation: maintenance-12.0/maintenance-12.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_plan/es/

[IMP] maintenance_plan: black, isort

152f8b8

[13.0][IMP] maintenance_plan: make maintenance plan multi-company com…

e565d08

…patible. includes migration scripts

[IMP] maintenance_plan: black, isort, prettier

357e12c

[MIG] maintenance_plan: Migration to 14.0

61f5718

[UPD] Update maintenance_plan.pot [UPD] README.rst

Added translation using Weblate (Italian)

eba10d2

Translated using Weblate (Italian)

d190cd6

Currently translated at 100.0% (69 of 69 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_plan/it/

Translated using Weblate (Italian)

9e6604d

Currently translated at 100.0% (69 of 69 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_plan Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_plan/it/

[IMP] maintenance_plan: next maintenance date tweaks

b07a3ae

* only consider request after the start maintenance date. * todo request ordered asc. * add more tests. maintenance_plan 14.0.1.0.2

etobella reviewed Aug 7, 2024

View reviewed changes

FernandoRomera force-pushed the 17.0-mig-maintenance_plan branch from f86fb60 to b4bb3bc Compare August 8, 2024 06:09

[MIG] maintenance_plan: Migration to 17.0

9f99863

FernandoRomera force-pushed the 17.0-mig-maintenance_plan branch from b4bb3bc to 9f99863 Compare August 8, 2024 06:11

OCA-git-bot added the ready to merge label Aug 8, 2024

etobella approved these changes Aug 8, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 8, 2024

OCA-git-bot merged commit aec528a into OCA:17.0 Aug 8, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 8, 2024

FernandoRomera mentioned this pull request Aug 8, 2024

[17.0][MIG] maintenance_timesheet: Migration to 17.0 #418

Merged

carlos-lopez-tecnativa reviewed Jan 15, 2025

View reviewed changes

carlos-lopez-tecnativa mentioned this pull request Jan 15, 2025

[17.0][FIX] maintenance_plan: Use 'active_id' instead of 'id' in action to fix error #439

Closed

victoralmau mentioned this pull request Feb 19, 2025

[17.0][OU-ADD] maintenance: Migration scripts OCA/OpenUpgrade#4654

Open

victoralmau added a commit to Tecnativa/maintenance that referenced this pull request Feb 20, 2025

[IMP] maintenance_plan: Define module as deprecated in readme

9675137

OCA#414 (comment)

This was referenced Feb 20, 2025

[17.0][IMP] maintenance_plan: Define module as deprecated in readme #470

Open

[17.0][MIG] maintenance_plan_activity: Migration to 17.0 #468

Open

[18.0][MIG] maintenance_plan: Migration to 18.0 #457

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] maintenance_plan: Migration to 17.0 #414

[17.0][MIG] maintenance_plan: Migration to 17.0 #414

FernandoRomera commented Jul 23, 2024

FernandoRomera commented Aug 7, 2024

pedrobaeza commented Aug 7, 2024

etobella Aug 7, 2024

FernandoRomera Aug 8, 2024

FernandoRomera Aug 8, 2024

etobella Aug 7, 2024

FernandoRomera Aug 8, 2024

etobella Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

etobella commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

victoralmau commented Nov 6, 2024

victoralmau commented Jan 15, 2025

carlos-lopez-tecnativa left a comment

carlos-lopez-tecnativa Jan 15, 2025

carlos-lopez-tecnativa Jan 15, 2025

carlos-lopez-tecnativa commented Jan 15, 2025

pedrobaeza commented Jan 15, 2025

victoralmau commented Feb 19, 2025

pedrobaeza commented Feb 19, 2025

[17.0][MIG] maintenance_plan: Migration to 17.0 #414

[17.0][MIG] maintenance_plan: Migration to 17.0 #414

Conversation

FernandoRomera commented Jul 23, 2024

FernandoRomera commented Aug 7, 2024

pedrobaeza commented Aug 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 8, 2024

etobella commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

victoralmau commented Nov 6, 2024

victoralmau commented Jan 15, 2025

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa commented Jan 15, 2025

pedrobaeza commented Jan 15, 2025

victoralmau commented Feb 19, 2025

pedrobaeza commented Feb 19, 2025