-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] readme model updated with oca img banner #642
base: master
Are you sure you want to change the base?
Conversation
@@ -7,6 +7,11 @@ | |||
{% endif %} | |||
{%- endmacro -%} | |||
|
|||
.. image:: https://odoo-community.org/web/image/4603934-dcc7fad0/readme_banner_OCA.png | |||
:target: https://odoo-community.org/get-involved#scrollTop=0?ref=u3kel3&utm_source=oca-readme-banner-module&utm_medium=referral&utm_campaign=become-member-2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implies the campaign should remain open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean the OCA sponsors recruitment campaign, yes, it stays open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need simpler urls and stable that are not tied to odoo implementation details. Otherwise they will rapidly become broken as we upgrade Odoo etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need simpler urls and stable that are not tied to odoo implementation details. Otherwise they will rapidly become broken as we upgrade Odoo etc...
That was the feeling I had but @sbidoul said it clearly :-)
The URL was created with a separate too where I put the original link and
added details like the source and the campaign name (but I can remove 2025
for example) to analyse how many people visited the website after clicking
on this banner.
Can you explain how to change a URL in odoo so that it stays the same after
a migration? And how I can use this separate tool so that it works as well?
Le ven. 7 févr. 2025, 08:38, Stéphane Bidoul ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In tools/gen_addon_readme.rst.jinja
<#642 (comment)>:
> @@ -7,6 +7,11 @@
{% endif %}
{%- endmacro -%}
+.. image:: https://odoo-community.org/web/image/4603934-dcc7fad0/readme_banner_OCA.png
+ :target: https://odoo-community.org/get-involved#scrollTop=0?ref=u3kel3&utm_source=oca-readme-banner-module&utm_medium=referral&utm_campaign=become-member-2025
I think we need simpler urls and stable that are not tied to odoo
implementation details. Otherwise they will rapidly become broken as we
upgrade Odoo etc...
—
Reply to this email directly, view it on GitHub
<#642 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGU2LZRFFSEZXJEV5UFXQSL2ORPJDAVCNFSM6AAAAABWT3OY4SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBRGAYDENBTGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
We can probably do somethings with Website Settings > Configuration > Redirects. |
Another comment I have is about the banner. It looks very big and too "advertising". If we see such a big banner on each addon page, either on pypi.org or our own app store, it will rapidly becoming tiring, I think. See for instance how it looks now on https://pypi.org/project/odoo-addon-mis-builder/. Can we do something less intrusive? |
So the starting point of the banner idea is the idea that many users use the OCA modules without even knowing that they can "give back" to the community by sponsoring it or becoming members. I understand the fear of annoying publicity but if it becomes annoying and in the same time we measure in 6-10 month that is inefficient, it will be a good reason to replace it or remove it completely. |
Yes I understand the goal, but I'm pretty sure that using PyPI blatantly as advertising medium would be frowned upon. We can achieve the same result with something a more discreet. |
ok, I understand. |
Milestone (Odoo version)
Module(s)
Fixes / new features
Readme model modified in order to display a OCA img banner on the top with a link inviting users to become members or sponsors