Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] l10n_th_account_tax (no merge to v14, to be added to v15) #272

Open
wants to merge 104 commits into
base: 14.0
Choose a base branch
from

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Oct 27, 2021

Because of difficulties in maintenance when feature grows, we decided to combine modules as following,
all will start with l10n_th_account

  1. l10n_th_account_tax

    • l10n_th_tax_invoice
    • l10n_th_withholding_tax
    • l10n_th_withholding_tax_cert
  2. l10n_th_account_tax_expense

    • l10n_th_expense_tax_invoice
    • l10n_th_expense_withholding_tax
  3. l10n_th_account_tax_multi

    • l10n_th_withholding_tax_multi
  4. l10n_th_account_tax_report

    • l10n_th_tax_report
    • l10n_th_withholding_tax_report
  5. l10n_th_account_wht_cert_form

    • l10n_th_withholding_tax_cert_form

IMPORTANT NOTE

The old module will still be in 14.0, but will be deprecated (removed) in version 15.0

@kittiu kittiu force-pushed the 14.0-add-l10n_th_account_tax branch 12 times, most recently from f2bb5dd to 5a54d63 Compare October 30, 2021 09:24
@kittiu
Copy link
Member Author

kittiu commented Oct 30, 2021

@Saran440 @ps-tubtim คิดว่า branch นี้คงยังไม่ merge ใน v14 ดีกว่าครับ ไม่น่ารันเทสผ่านเพราะมัน conflict กับของเก่า
คงต้องเอาไว้ ขึ้นตอน v15 ทีเดียว

@kittiu kittiu force-pushed the 14.0-add-l10n_th_account_tax branch 3 times, most recently from a3cd6b3 to 2ef1eba Compare October 31, 2021 14:24
@kittiu kittiu changed the title [14.0][ADD] l10n_th_account_tax_xxx [14.0][ADD] l10n_th_account_tax Nov 1, 2021
@kittiu kittiu force-pushed the 14.0-add-l10n_th_account_tax branch 3 times, most recently from 3e68d9d to 7d8ec16 Compare November 4, 2021 09:13
@kittiu kittiu force-pushed the 14.0-add-l10n_th_account_tax branch from 27186b7 to 1f27c7a Compare November 5, 2021 07:19
@Saran440 Saran440 force-pushed the 14.0-add-l10n_th_account_tax branch 5 times, most recently from 434b0fc to 2523cf9 Compare November 23, 2021 10:53
@kurogeek
Copy link

Hi, how can you change modules' names while preserving commit histories?

Following this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 only works if the module's name is not changed.

@kittiu
Copy link
Member Author

kittiu commented Aug 22, 2022

Hi, how can you change modules' names while preserving commit histories?

Following this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 only works if the module's name is not changed.

I also not sure about this. I think it couldn't.

But for the l10n_th_account_tax... I consider it a new module anyway.

@kittiu kittiu changed the title [14.0][ADD] l10n_th_account_tax (no merge, to v15) [14.0][ADD] l10n_th_account_tax (no merge to v14, to be added to v15) Aug 22, 2022
@Saran440 Saran440 added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants