[14.0][MIG] l10n_th_withholding_tax_multi #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kittiu, |
komsan-S
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
12 times, most recently
from
de3d068
to
a8824dd
Compare
kittiu
reviewed
Dec 2, 2020
| @@ -32,7 +39,7 @@ def _onchange_payment_difference_handling(self): | |||
| "wt_tax_id": line.wt_tax_id.id, | |||
| "account_id": line.wt_tax_id.account_id.id, | |||
| "name": line.wt_tax_id.display_name, | |||
| "amount": -line.wt_tax_id.amount / 100 * line.price_subtotal, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you point me to where is the change? Thank you!
|
@komsan-S can you rebase l10n-thailand again. We got the new version of the dot files in this repo. |
kittiu
reviewed
Dec 2, 2020
oca_dependencies.txt
Outdated
Comment on lines
2
to
3
|
|
||
| account-payment https://github.com/ecosoft-odoo/account-payment.git 14.0-mig-account_payment_multi_deduction d3a881f |
There was a problem hiding this comment.
Suggested change
| account-payment https://github.com/ecosoft-odoo/account-payment.git 14.0-mig-account_payment_multi_deduction d3a881f | |
| account-payment |
komsan-S
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
2 times, most recently
from
d296876
to
9553711
Compare
ps-tubtim
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
4 times, most recently
from
a7d7977
to
47473b9
Compare
ps-tubtim
reviewed
Sep 4, 2021
Comment on lines
20
to
24
| amount_residual = sum(move_ids.mapped("amount_residual")) | ||
| amount_total = sum(move_ids.mapped("amount_total")) | ||
| if float_compare(amount_residual, amount_total, 2) == 0 and len(inv_lines) > 1: | ||
| self.payment_difference_handling = "reconcile_multi_deduct" | ||
| self._onchange_payment_difference_handling() |
There was a problem hiding this comment.
I improve this code for use in case of registering a payment with multi invoices.
Waiting for
ps-tubtim
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
from
47473b9
to
c5f0ab1
Compare
ps-tubtim
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
2 times, most recently
from
0fd2882
to
183a841
Compare
ps-tubtim
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
from
183a841
to
994306e
Compare
kittiu
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
from
ac02e88
to
1cc2e2c
Compare
kittiu
force-pushed
the
14.0-mig-l10n_th_withholding_tax_multi
branch
from
1cc2e2c
to
d6c0b8c
Compare
|
@Saran440 @ps-tubtim This PR is ready for review. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: