Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[16.0][FIX] pinned requests_pkcs12 version due cryptography dependency" #3987

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

yajo
Copy link
Member

@yajo yajo commented Feb 3, 2025

Aquí revierto #3954 pues el fix empezó a romper nuestro CI:

ERROR: Cannot install requests_pkcs12 because these package versions have conflicting dependencies. The conflict is caused by:
    requests-pkcs12 1.22 depends on requests>=2.26.0
    The user requested (constraint) requests==2.25.1
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

En resumidas cuentas, lo que viene diciendo es que al exigir requests-pkcs12==1.22, estamos rompiendo este constraint de Odoo.

Esto me ha empezado a suceder porque usamos el archivo requirements.txt de Odoo como un pip contraint y no como un pip requirements. Algo así:

pip install \
    -r https://github.com/OCA/l10n-spain/raw/refs/heads/16.0/requirements.txt \
    -c https://github.com/odoo/odoo/raw/refs/heads/16.0/requirements.txt

Lo hacemos así para siempre coger las dependencias más modernas que necesitan los módulos de OCA, pero respetando las restricciones últimas que establece Odoo. Para que esto funcione, es mejor que los repos de OCA no definan restricciones de versiones1, y dejar que sea Odoo quien las restrinja.

Dicho de otra forma, si usas el requirements.txt de OCA, es mejor que dicho archivo no congele versiones para que sea Odoo quien lo haga.

Dejo el PR en borrador hasta que compruebe si esto realmente resuelve el problema.


1 Las restricciones de versiones que tengan sentido se deben poner, por supuesto (si el módulo es incompatible con cierta versión de cierta dependencia). Pero si se ponen solo para evitar conflictos o reinstalaciones, es contraproducente, y es preferible hacerlo con constraints como se explica arriba.

@moduon MT-8983

…ependency"

This reverts commit 6e3f594.

The fix started producing other dependency conflicts:

ERROR: Cannot install requests_pkcs12 because these package versions have conflicting dependencies.
The conflict is caused by:
    requests-pkcs12 1.22 depends on requests>=2.26.0
    The user requested (constraint) requests==2.25.1
@OCA-git-bot
Copy link
Contributor

Hi @ao-landoo,
some modules you are maintaining are being modified, check this out!

@yajo yajo marked this pull request as ready for review February 3, 2025 14:41
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola! ao-landoo ya no es mantendor, ¿quíén podría revisar este PR por favor @OCA/local-spain-maintainers ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 8, 2025
@pedrobaeza
Copy link
Member

@extrememicro fue el que tuvo el problema, así que debéis acordar entre los dos la solución adecuada para todos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants