-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] p7m file encoded twice #4404
base: 16.0
Are you sure you want to change the base?
Conversation
Sometimes suppliers encode the file twice. The first step to decode the file is not enough. Change the behaviour to be able to decode the file until it not coded in b64
l10n_it_fatturapa/__manifest__.py
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
{ | |||
"name": "ITA - Fattura elettronica - Base", | |||
"version": "16.0.1.3.0", | |||
"version": "16.0.1.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yle-scopea , no need for this change, the version is bumped automatically on merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will avoid this next time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but you should avoid it this time as well 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Hi @yle-scopea , thanks for your PR! Could you create an issue (if possibile with a file to reproduce the problem) so we can track this problem across versions? |
I'm not able to provide you a file to test because it's my customer file not mine. Sorry. I will ask to my customer if I can share the file with you in an issue. Do I need to create the issue even if I don't have file to provide? Thanks |
@yle-scopea yes please, open the issue as in this repo we try to track changes across versions and we can then link this PR to the issue Do you know if there's a procedure to double encode the file? So we can use one for testing |
Sometimes suppliers encode the file twice. The first step to decode the file is not enough. Change the behaviour to be able to decode the file until it not coded in b64