Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] p7m file encoded twice #4404

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

yle-scopea
Copy link

Sometimes suppliers encode the file twice. The first step to decode the file is not enough. Change the behaviour to be able to decode the file until it not coded in b64

Sometimes suppliers encode the file twice. The first step to decode the file is not enough.
Change the behaviour to be able to decode the file until it not coded in b64
@@ -6,7 +6,7 @@

{
"name": "ITA - Fattura elettronica - Base",
"version": "16.0.1.3.0",
"version": "16.0.1.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yle-scopea , no need for this change, the version is bumped automatically on merge

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will avoid this next time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but you should avoid it this time as well 😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@francesco-ooops
Copy link
Contributor

Hi @yle-scopea , thanks for your PR!

Could you create an issue (if possibile with a file to reproduce the problem) so we can track this problem across versions?

@yle-scopea
Copy link
Author

Hi @francesco-ooops

I'm not able to provide you a file to test because it's my customer file not mine. Sorry.
But, the file is twice encoded in Base64. So first time, we get a new base64 raw data instead of XML readable file.

I will ask to my customer if I can share the file with you in an issue. Do I need to create the issue even if I don't have file to provide?

Thanks

@francesco-ooops
Copy link
Contributor

@yle-scopea yes please, open the issue as in this repo we try to track changes across versions and we can then link this PR to the issue

Do you know if there's a procedure to double encode the file? So we can use one for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0] p7m file encoded twice by the supplier failed to be loaded
3 participants