Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_br_account: fix _compute_fiscal_document_ids #3378

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[16.0][FIX] l10n_br_account: fix _compute_fiscal_document_ids #3378

merged 1 commit into from
Sep 24, 2024

Conversation

WesleyOliveira98
Copy link
Contributor

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

@WesleyOliveira98 WesleyOliveira98 marked this pull request as ready for review September 23, 2024 18:28
@WesleyOliveira98 WesleyOliveira98 changed the title [16.][FIX] l10n_br_account: fix _compute_fiscal_document_ids [16.0][FIX] l10n_br_account: fix _compute_fiscal_document_ids Sep 23, 2024
kaynnan
kaynnan approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@kaynnan kaynnan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCTIONAL REVIEW] - Approved

Bill:
image

Obs: o Journal Entries não consegui validar corretamente por um erro de readonly, reportei esse acontecimento na Issue 3379

@marcelsavegnago
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3378-by-marcelsavegnago-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6972dcc into OCA:16.0 Sep 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9aba88. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 16.0-l10n_br_account-fix-compute_fiscal_document_ids branch September 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaynnan kaynnan kaynnan approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WesleyOliveira98 @OCA-git-bot @marcelsavegnago @rvalyi @antoniospneto @kaynnan