Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] IE/RG UX #1403

Merged
merged 1 commit into from
May 25, 2021
Merged

[FIX] IE/RG UX #1403

merged 1 commit into from
May 25, 2021

Conversation

mileo
Copy link
Member

@mileo mileo commented May 24, 2021

Antes do PR:

image

@rvalyi
Copy link
Member

rvalyi commented May 24, 2021

OK mas por favor nao esquece esse #1374

@mileo
Copy link
Member Author

mileo commented May 24, 2021

OK mas por favor nao esquece esse #1374

Sim, estamos analisando internamente, mas não é algo que eu possa decidir sozinho. cc @ananiasfilho

@rvalyi
Copy link
Member

rvalyi commented May 24, 2021

OK mas por favor nao esquece esse #1374

Sim, estamos analisando internamente, mas não é algo que eu possa decidir sozinho. cc @ananiasfilho

A gente pode ate ter muitas divergencias, mas eu accredito que sobre esse ponto tem um interesse mutuo bem forte de dar um basta nas localizaçoes tabajaras que estao aparecendo na boca dos vendedores da Odoo SA de uma vez por todas. Quanto a questao de nao usar isso para fechar, a gente tem literalmente centenas de repos que provam que nao é a tradiçao da casa...

E sobre o risco de uma outra empresa usar esses 3 modulos para fazer uma localizaçao fechada completa melhor e crível, so na quinta re-incarnaçao talvez...

@rvalyi
Copy link
Member

rvalyi commented May 25, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1403-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f9d6c5c into OCA:12.0 May 25, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 888abf3. Thanks a lot for contributing to OCA. ❤️

@mileo mileo mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mileo @rvalyi @OCA-git-bot @marcelsavegnago