[16.0][IMP] Allow to use the storage either from the payment mode or from the payment method #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he payment method
AnizR
force-pushed
the
16.0-improve_account_payment_method_fs_storage
branch
3 times, most recently
from
473d250 to
516c03d
Compare
acsonefho
reviewed
Feb 17, 2025
| @@ -103,6 +103,8 @@ def test_payment_method_fs_storage(self): | |||
| order.draft2open() | |||
| with self.with_custom_method(): | |||
| action = order.open2generated() | |||
| # commit need to be performed in order to perform the 'postcommit' | |||
| self.env.cr.commit() # pylint: disable=E8102 | |||
There was a problem hiding this comment.
Why not doing your own sub-savepoint?
There was a problem hiding this comment.
As discussed, adding a savepoint wasn't possible since I was commiting (savepoints are destroyed once the transaction is commited).
But, I could avoid to commit and manualy run the 'postcommit' of the cursor.
Thanks for the suggestion!
AnizR
force-pushed
the
16.0-improve_account_payment_method_fs_storage
branch
2 times, most recently
from
a640068 to
ccff7ac
Compare
acsonefho
approved these changes
Feb 17, 2025
…ge as late as possible
AnizR
force-pushed
the
16.0-improve_account_payment_method_fs_storage
branch
from
ccff7ac to
7732a10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reopened: #1279 that aims to push payment file to a distant storage by @lmarion-source.
With a small twist:
IMO, pushing to the storage should be done as late as possible because we may not have control over it.
Therefore, if an error occurs after sending the file we may not be able to remove the file from the storage.
I had a case where my client had an error when changing the state of a payment order to 'generated'. He tried multiple times and sent duplicate of a payment file because the error was thrown after the file's sending.