Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_payment_partner: Migration to 18.0 #1415

Open
wants to merge 162 commits into
base: 18.0
Choose a base branch
from

Conversation

absal-smile
Copy link

No description provided.

Alexis de Lattre and others added 30 commits February 7, 2025 09:07
- account_payment_partner
- account_payment_sale
- account_payment_sale_stock
- account_payment_purchase

Filter the selection of invoices per payment type.
Add active field on payment.mode and payment.mode.type.
Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA
* Clean files
* Replace deprecated workflow calls
* Translation template files
* Translations to spanish
* Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices
* FIX: Remove deprecated tag type
* move unused file + cleanup code
* Add sale_ok and purchase_ok filters in partner/sale/purchase form views
* Use widget=selection for payment_mode_id fields
* Update demo data
* Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
* Forgot to remove a usecase of debit_denied
* Add ACL
* Better filters on payment.order.create wizard
* Add default values for those filters on payment.mode
* FIX remove coma at end of line
* Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers
* Remove label field

  There's already a field in the payment mode called 'note' that is
  printed on the invoices, so there's no need of another field for
  that purpose. This field is added by account_banking_payment_export

* Bump version numbers
* es translations
* Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016

Improvements include:
- full re-organisation of modules and big re-organisation of the code
- simplification of the code related to the fact that support for direct debit is now in t
he base module, not added by an optional module account_direct_debit (module was removed)
- new design of the wizard to select move lines to pay
- support for non-SEPA file transfer-
- support for German direct debit SEPA files (fixes bug OCA#129)
- remove workflow of payment.order
* Finalise the wizard of selection of move lines to pay
* Add button "Add to payment/debit order" on invoice form view
* Started to integrate payment transfer in account_payment_order (not finished at all though)
* Copy payment mode and mandate from invoice to refund
* Run dos2unix on the few files that had DOS carriage return
* Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner)
* Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange
* Move field bank_account_required from module account_payment_partner to account_payment_mode
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
* Change copyright and author after company merging
* Fill payment mode in invoices if none is provided

  Using same method as in upstream, payment mode is filled on invoice creation if
  no payment method is provided. This way, we don't need to install
  account_payment_sale if we don't want to handle several payment modes at sales
  level. Even more, if we install the module later and we have already existing
  sales orders without payment mode filled, those orders will be invoiced with
  the customer payment mode.

* Signature changed in convert_to_write
… not mandatory) and create a traceback for the user

Use t-if
Currently translated at 100,0% (18 of 18 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_payment_partner/es/
…on + show it on invoice report

* IMP: Add options to show partner bank account on invoice report
* FIX: Don't auto-assign partner bank account due to problems when you have a direct debit payment
  method with bank_account_link = 'fixed'. Bank account is shown through new mechanism.
miquelalzanillas and others added 19 commits February 7, 2025 09:07
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/it/
…ions in HTML module descriptions are deprecated since Odoo 17
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/sv/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/it/
…invoices

This error is happening because the salesperson has not access to payment_method_id.

With this changes we avoid the error and the invoices are printed like normally.

TT31296
@AlexPForgeFlow
Copy link

Hi @absal-smile !
Can you include test-requirements.txt file in order to run tests?

@absal-smile absal-smile force-pushed the 18.0-mig-account_payment_partner branch from b13991f to 617948c Compare February 21, 2025 15:10
@absal-smile
Copy link
Author

i have already add the test-requirements with this code
odoo-addon-account_payment_mode @ git+https://github.com/OCA/bank-payment.git@refs/pull/791/head#subdirectory=account_payment_mode
Inside the test-requirements.txt file you should put the link to the PR involved with the next format, all in one line (Version >= 17):
odoo-addon-<module_name> @ git+https://github.com/OCA/.git@refs/pull/<PR_number>/head#subdirectory=<module_name>

@ioans73
Copy link
Member

ioans73 commented Feb 24, 2025

Hi @absal-smile
Can you fix it?

@absal-smile
Copy link
Author

@ioans73 fix what ??

@pedrobaeza
Copy link
Member

I think the problem is that account_payment_mode is not merged and this is not using https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Anyway, I see 2 "pre-commit auto fixes" commits, which doesn't seem correct.

@absal-smile absal-smile force-pushed the 18.0-mig-account_payment_partner branch from 617948c to 3892dfb Compare February 24, 2025 16:47
@absal-smile absal-smile force-pushed the 18.0-mig-account_payment_partner branch from 3892dfb to 9eab639 Compare February 24, 2025 16:48
@rousseldenis
Copy link
Contributor

@absal-smile Could you try rebasing as I want to see if ECLA sync is ok ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.