[18.0][MIG] account_banking_mandate #1407
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug OCA#96 bad use of new API * [Usability] mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view * Replace tabs by spaces in mandate views * account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule. Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers * Bump version numbers * es translations
* Add creditor identifier field to report mandate. * Translate. * Split basic and sepa mandate * Use api.multi instead * Make format field required
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided Using same method as in upstream, mandate is filled on invoice creation if no one is provided. This way, we don't need to install account_banking_mandate_sale if we don't want to handle several mandates at sales level.
…ically on the payment line'
…date + Add valid_mandate field and fix onchange (cherry picked from commit 25d2e4d)
add tests and constrains
* Fix tests due to upstream change Odoo has added a constraint for avoiding a company currency change if there are move lines, making these tests to fail, as the currency is changed to EUR. With this commit, we create a new company with EUR currency for avoiding the problem. This commit also changes account_banking_mandate for not duplicating mandate number, as it was detected during the test creation. Similar to 1f8e345 * Avoid errors in tests when run with other modules * More adaptations to make tests to work properly All these problems comes from using demo data.
Currently translated at 100,0% (82 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/es/
Currently translated at 68,3% (56 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/ca/
Currently translated at 100.0% (109 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/es/
Currently translated at 100.0% (109 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/fr/
Currently translated at 81.6% (89 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
Currently translated at 81.6% (89 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
Currently translated at 81.6% (89 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
Currently translated at 81.6% (89 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
Currently translated at 100.0% (109 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/fr/
Currently translated at 81.6% (89 of 109 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/
Currently translated at 100.0% (104 of 104 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/es/
Currently translated at 100.0% (104 of 104 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/es/
Currently translated at 76.9% (80 of 104 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/it/
…iew of account.payment.line with the same condition as the tree view. TT45405
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/
Currently translated at 92.2% (95 of 103 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_mandate/nl/
NEW FEATURES
- activate 'in_payment' payment_state on invoices... at last !
- payment order numbering: add ability to have a sequence specific to a particular payment mode (optional)
- add show account number policy "first_last" to show N first and N last characters of bank account number
SMALL IMPROVEMENTS
- account.payment.method: rename field "payment_order_only" to "payment_order_ok" for naming consistency with the field of account.payment.mode. Auto-set "payment_order_ok" of payment mode from the equivalent field of payment method. Migration scripts provided for account.payment.method and the data of SEPA credit transfer and SEPA direct debit.
- payment order attachment: add M2O payment_file_id that points to the payment file. No more need for a simplified attachment form view.
- keep the spaces in the scrambled bank account number, so that the user easily understands that it is a "scrambled" bank account number
- add field acc_number_scrambled on res.partner.bank for easy and direct use of scrambled account number
SIMPLIFICATION / CODE CLEANUP
- remove field partner_bank_id on account.move.line
- move code for scrambled account number from qweb report to res.partner.bank class
- remove boolean field show_bank_account_from_journal from account.payment.mode: we now consider that this option is always true i.e. when account_payment_partner is installed, Odoo takes the bank accounts to display on the customer invoice from the payment mode (if the payment mode is empty, it displays all the bank accounts of the company). As a consequence, hide partner_bank_id on customer invoice form view.
- remove fields inbound_payment_order_only and outbound_payment_order_only from account.journal : these 2 fields were not used!
- add check_company=True where it was missing and remove code of constraint that checks company consistency
- re-organise form view of payment order to equilibrate between left column and right column
TECHNICAL:
- replace @api.onchange by computed readonly=False store=True fields
- remove (or reduce) the use of demo data in tests
- speed-up tests by using tracking_disable=True
- Replace (6, 0, []) and (0, 0, {}) by Command.set() and Command.create()
- add sql unicity constraint on payment order number per company
… linked to debit orders that don't have mandate_required = True
…y check_company=True on mandate_id field
On payment method, check that mandate_required is only be True on inbound methods.
…account.payment.line (same as in account_payment_order)
If we use a payment order with mandate required, mandate is placed before bank account (more logic) and bank account becomes readonly: it is set by the mandate.
|
Hi Alexis, why did you start from version 16 to make the migration instead of 17? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.