[14.0][FIX/IMP] account_payment_order: use payment_reference if present for out payments #1371
Conversation
…nt for out payments
FrankC013
force-pushed
the
14.0-fix-account_payment_order-communication
branch
from
cbc15f0
to
196e1c1
Compare
There was a problem hiding this comment.
@FrankC013 This is 14.0 and it supersedes an already merged 16.0 PR???? It cannot supersedes if it's merged and it's another version. This seems a backport. Please check it out.
| @@ -48,7 +48,7 @@ def _get_payment_order_communication(self): | |||
| if (self.reference_type or "none") != "none": | |||
| communication = self.ref | |||
| elif self.is_purchase_document(): | |||
| communication = self.ref or self.payment_reference | |||
| communication = self.payment_reference or self.ref or "" | |||
There was a problem hiding this comment.
I added or "" because, in version 16, the _get_payment_order_communication function is divided into two separate methods: _get_payment_order_communication_direct and _get_payment_order_communication_full.
If I remove the or "", the line communication += " " + " ".join(references) throws the error unsupported operand type(s) for +=: 'bool' and 'str', as self.ref can be False. To avoid this issue, we can either split the function as in version 16 or handle it with or "" to ensure communication is always a string.
|
Superseded by #1372 |
Supersedes #1331