[16.0][IMP] account_payment_mode: change type of payment_mode.note field #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this improvement as something good, but you should provide a migration script for converting previous content to HTML. There's an openupgradelib method for that. |
|
I hope it was the right way to do it ;) |
|
I'm afraid not. That's a hook, not a migration script. A sample (not with the same change though): https://github.com/OCA/contract/tree/16.0/contract/migrations |
clementelabore
force-pushed
the
pr-account-payment-mode-note-html
branch
from
d4ecf1b to
7984c5c
Compare
|
it should be ok when OCA/openupgradelib#384 will be merged |
|
Please squash commits into one |
clementelabore
force-pushed
the
pr-account-payment-mode-note-html
branch
from
41fa745 to
7a6f72c
Compare
…om Text to Html also add migration script
clementelabore
force-pushed
the
pr-account-payment-mode-note-html
branch
from
7a6f72c to
1dd87a0
Compare
pedrobaeza
approved these changes
Oct 4, 2024
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type of payment_mode.note from Text to Html
This to improve display on Invoice document