[16.0][ADD] account_payment_order_filename: new module #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new module account_payment_order_filename to let the user customize the file generated. This behavior use sequence to also have the possibility to generate a unique filename if necessary
acsonefho
force-pushed
the
account_payement_order_filename
branch
from
35ff8e7
to
0ed12ad
Compare
sbidoul
reviewed
Aug 14, 2024
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module let the possibility to the user to specify a sequence for the filename generation on the payment order. |
There was a problem hiding this comment.
Could you add a CONTEXT.rst explaining when this is useful?
A question I'd ask is in which circumstance we need a different number for the files than the payment orders.
|
Why does this module override the specific sepa file and not I took a look, it would be much easier, just depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new module account_payment_order_filename to let the user customize the file generated. This behavior use sequence to also have the possibility to generate a unique filename if necessary