[16][FIX] account_move_line_reconcile_manual fix foreign currency reconciliation #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexis-via, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
mourad-ehm
approved these changes
Sep 30, 2024
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the full reconciliation case for the cases when all entries have the same foreign currency. We compare the currency amount to detect if the reconciliation is full instead of the company currency.
After this PR there is one more problematic case : when we try to reconcile a line with foreign currency with a ligne with company currency.
During reconciliation, Odoo convert the line with company currency to foreign currency... and in the wizard, the company currency amounts are compared.
So in case of full reconciliation (with writeoff) it does not work. I have added the issue in the README.
@alexis-via