Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] [16.0] account_invoice_merge_attachment #1812

Open
wants to merge 8 commits into
base: 16.0
Choose a base branch
from
Open

[MIG] [16.0] account_invoice_merge_attachment #1812

wants to merge 8 commits into from

Conversation

fcayre
Copy link
Member

@fcayre fcayre commented Oct 7, 2024

No description provided.

@fcayre fcayre force-pushed the 16.0-mig-account_invoice_merge_attachment branch from febeb02 to 8cef776 Compare October 7, 2024 12:40
@fcayre fcayre force-pushed the 16.0-mig-account_invoice_merge_attachment branch 5 times, most recently from 64685f8 to 3d163f9 Compare October 7, 2024 17:05
@fcayre fcayre force-pushed the 16.0-mig-account_invoice_merge_attachment branch from 3d163f9 to ccf0ea9 Compare October 7, 2024 18:05
legalsylvain
legalsylvain reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff review. LGTM.

remi-filament
remi-filament approved these changes Oct 9, 2024
View reviewed changes
Copy link

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fcayre

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-filament remi-filament remi-filament approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@fcayre @OCA-git-bot @legalsylvain @remi-filament @adrienpeiffer @benwillig @oca-transbot @oca-travis @thomaspot @mourad-ehm