Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] partner_statement: context_today() instead of today() #1280

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dannyadair
Copy link
Contributor

The date shown on the report should be based on the client's timezone not UTC. (can be off by a day)

@OCA-git-bot
Copy link
Contributor

Hi @MiquelRForgeFlow,
some modules you are maintaining are being modified, check this out!

@dannyadair
Copy link
Contributor Author

Please note, the tests are failing on another module, seemingly unrelated:

2025-02-04 23:23:55,273 274 ERROR odoo odoo.addons.account_purchase_stock_report_non_billed.tests.test_account_purchase_stock_report_non_billed: FAIL: TestAccountPurchaseStockReportNonBilled.test_04_report_move_full_invoice_refund
Traceback (most recent call last):
  File "/__w/account-financial-reporting/account-financial-reporting/account_purchase_stock_report_non_billed/tests/test_account_purchase_stock_report_non_billed.py", line 119, in test_04_report_move_full_invoice_refund
    self.assertIn(move.id, domain_ids)
AssertionError: 87 not found in []

@AaronHForgeFlow AaronHForgeFlow changed the title Fix: context_today() instead of today() [16.0][FIX] partner_statement: context_today() instead of today() Feb 5, 2025
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyadair
Copy link
Contributor Author

@AaronHForgeFlow Thank you for the title change. Sorry I will try to keep this notation in mind in the future.

@AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow Thank you for the title change. Sorry I will try to keep this notation in mind in the future.

Thank you. Can you also include the module name in the commit message?

The date shown on the report should be based on the client's timezone not UTC. (can be off by a day)
@dannyadair
Copy link
Contributor Author

@AaronHForgeFlow Thank you for the title change. Sorry I will try to keep this notation in mind in the future.

Thank you. Can you also include the module name in the commit message?

Done.

@AaronHForgeFlow
Copy link
Contributor

Thank you @dannyadair

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1280-by-AaronHForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a836dd9 into OCA:16.0 Feb 5, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 225ce9a. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow
Copy link
Contributor

@dannyadair could you do forward ports?

@dannyadair
Copy link
Contributor Author

Forward-ported to 17.0 in #1282
(18.0 does not have partner_statement yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants