Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zulip: electron_32 -> electron #388734

Closed

Conversation

FriedrichAltheide
Copy link
Contributor

  • zulip switch from electron_32 to electron because electron_32 is EOL

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 10, 2025
@nix-owners nix-owners bot requested a review from andersk March 10, 2025 16:20
@SuperSandro2000
Copy link
Member

Did you test the applications by opening it and using it a bit?

@andersk
Copy link
Contributor

andersk commented Mar 10, 2025

Upgrading Electron to a newer major version is known not to work in general: #279545 (comment)

So even if we carefully test a specific upgrade and it happens to work, we need to pin to a known-working version of electron_NN rather than electron.

@nbdd0121
Copy link
Contributor

I believe the issue here is that electron 32 is EOL and now it's failing to evaluate without permittedInsecurePackages. @andersk perhaps you want to upgrade upstream and cut a new release?

@devurandom
Copy link
Contributor

Upstream PR to update Electron: zulip/zulip-desktop#1413

@FriedrichAltheide
Copy link
Contributor Author

Closed in favour of #390714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants