Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal: remove unused code from < 1.7.0 #381734

Merged
merged 4 commits into from
Feb 15, 2025

Conversation

donovanglover
Copy link
Member

Part of #380143

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: crystal Programming language - https://crystal-lang.org/ label Feb 13, 2025
@donovanglover donovanglover requested a review from a team February 13, 2025 12:12
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 13, 2025
@donovanglover donovanglover marked this pull request as draft February 13, 2025 13:04
@donovanglover donovanglover changed the title crystal: remove unused patch from < 1.2.0 crystal: remove unused code from < 1.7.0 Feb 13, 2025
@donovanglover donovanglover marked this pull request as ready for review February 13, 2025 13:06
@wolfgangwalther
Copy link
Contributor

Can you elaborate why you think that < 1.7.0 is unused?

The oldest version I see used in that file is version = "1.2.2";.

@donovanglover
Copy link
Member Author

I simplified the PR title a bit. Eval says 0 rebuilds so this should just be removing unused conditionals

@wolfgangwalther wolfgangwalther merged commit 73bf7bb into NixOS:master Feb 15, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: crystal Programming language - https://crystal-lang.org/ 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants